Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Mar 2019 21:07:25 +0000 (UTC)
From:      "Bradley T. Hughes" <bhughes@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r495526 - head/www/node10
Message-ID:  <201903122107.x2CL7Pk0092522@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bhughes
Date: Tue Mar 12 21:07:24 2019
New Revision: 495526
URL: https://svnweb.freebsd.org/changeset/ports/495526

Log:
  www/node10: set environment variables for host build
  
  The Node.js build system supports cross-compilation via node-gyp, which
  picks up CC, CXX, LINK, C*FLAGS, and LDFLAGS from the environment for the
  target build, but not for the host. We need to set the environment variables
  for the "host" build.
  
  This unbreaks the build on powerpc64.
  
  PR:		233835
  Reported by:	Piotr Kubaj <pkubaj@anongoth.pl>
  Sponsored by:	Miles AS
  Differential Revision:	https://reviews.freebsd.org/D19250

Modified:
  head/www/node10/Makefile

Modified: head/www/node10/Makefile
==============================================================================
--- head/www/node10/Makefile	Tue Mar 12 21:05:39 2019	(r495525)
+++ head/www/node10/Makefile	Tue Mar 12 21:07:24 2019	(r495526)
@@ -13,7 +13,6 @@ COMMENT=	V8 JavaScript for client and server
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/LICENSE
 
-BROKEN_powerpc64=	fails to build: KeyError: 'action'
 BROKEN_SSL=		openssl libressl libressl-devel
 BROKEN_SSL_REASON=	Node.js 10.x LTS requires OpenSSL 1.1.x or the BUNDLED_SSL option enabled
 ONLY_FOR_ARCHS=		aarch64 amd64 armv6 armv7 i386 powerpc64
@@ -32,6 +31,7 @@ OPTIONS_EXCLUDE_aarch64=	DTRACE
 # dt_modtext:/usr/src/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c(820): arm not implemented
 OPTIONS_EXCLUDE_armv6=		DTRACE
 OPTIONS_EXCLUDE_armv7=		DTRACE
+OPTIONS_EXCLUDE_powerpc64=	DTRACE
 
 BUNDLED_SSL_DESC=		Use node.js's bundled OpenSSL implementation
 BUNDLED_SSL_USES_OFF=		ssl
@@ -61,7 +61,9 @@ SHEBANG_FILES=	tools/specialize_node_d.py tools/genv8c
 
 PREFIX_RELDEST=	${PREFIX:S,^${DESTDIR},,}
 REINPLACE_ARGS=	-i ''
-MAKE_ENV+=	CC.host=${CC} CXX.host=${CXX} LINK.host=${CXX} LINK.target=${CXX}
+MAKE_ENV+=	CC.host=${CC} CFLAGS.host="${CFLAGS}" \
+		CXX.host=${CXX} CXXFLAGS.host="${CXXFLAGS}" \
+		LINK.host=${CXX} LDFLAGS.host="${LDFLAGS}"
 
 LIB_DEPENDS+=	libcares.so:dns/c-ares\
 		libuv.so:devel/libuv \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903122107.x2CL7Pk0092522>