From owner-freebsd-current@FreeBSD.ORG  Sat Feb 21 16:38:15 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id A904816A4CE; Sat, 21 Feb 2004 16:38:15 -0800 (PST)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.10/8.12.9) with ESMTP id i1M0cEHS058986;
	Sat, 21 Feb 2004 19:38:14 -0500 (EST)
	(envelope-from green@green.homeunix.org)
Received: from localhost (green@localhost)i1M0cEoF058982;
	Sat, 21 Feb 2004 19:38:14 -0500 (EST)
Message-Id: <200402220038.i1M0cEoF058982@green.homeunix.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Daniel Eischen <eischen@vigrid.com>
In-Reply-To: Message from Daniel Eischen <eischen@vigrid.com> 
	<Pine.GSO.4.10.10402211822020.7870-100000@pcnet5.pcnet.com> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 21 Feb 2004 19:38:13 -0500
Sender: green@green.homeunix.org
cc: current@FreeBSD.org
Subject: Re: Testers wanted: reentrant resolver 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Feb 2004 00:38:16 -0000

Daniel Eischen <eischen@vigrid.com> wrote:
> On Fri, 20 Feb 2004, Brian F. Feldman wrote:
> 
> > Daniel Eischen <eischen@vigrid.com> wrote:
> > 
> > > > Could you take a look at my test program (that I put in src/tools/) to see 
> > > > if I made any pthreading errors?
> > > 
> > > Where in src/tools?
> > 
> > It's in src/tools/regression/gaithrstress.
> 
> Yes, it looks fine to me.
> 
> One other thing about your patch, probably minor.  Since h_error
> is only used for the main thread now, multithreaded applications
> that haven't been recompiled will still be referencing it
> instead of the new function.  This would seem to break the ABI,
> right?  These older applications will pick up the wrong h_error.

That's right; applications that use the mostly-deprecated h_errno API will 
have to be recompiled if they want to get the right error codes.  I don't 
see a way around that, so I'm not worried about it -- and I don't think any 
application that doesn't do its own big giant lock around all 
gethostbyname() calls should be using h_errno; if it's using getaddrinfo(), 
the correct API for accessing errors is there.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\