From owner-freebsd-current@FreeBSD.ORG  Wed Feb 11 15:31:31 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C615BC4F
 for <freebsd-current@freebsd.org>; Wed, 11 Feb 2015 15:31:31 +0000 (UTC)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net
 [199.48.129.229]) by mx1.freebsd.org (Postfix) with ESMTP id A06B7F92
 for <freebsd-current@freebsd.org>; Wed, 11 Feb 2015 15:31:31 +0000 (UTC)
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
 id 467EB5A9F25; Wed, 11 Feb 2015 15:31:30 +0000 (UTC)
Date: Wed, 11 Feb 2015 15:31:30 +0000
From: Brooks Davis <brooks@freebsd.org>
To: Chris Torek <chris.torek@gmail.com>
Subject: Re: LOCAL_MTREE vs DB_FROM_SRC
Message-ID: <20150211153130.GB23837@spindle.one-eyed-alien.net>
References: <CAPx1Gvf8v1q2JkmzYF9ryoPk=XKYTiUG7gnu5TDXGn_7kqLd+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX"
Content-Disposition: inline
In-Reply-To: <CAPx1Gvf8v1q2JkmzYF9ryoPk=XKYTiUG7gnu5TDXGn_7kqLd+Q@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 15:31:31 -0000


--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 10, 2015 at 06:43:06PM -0800, Chris Torek wrote:
> (Apologies for google mail, I moved a while back and my office at home is
> still not up and hence my regular FreeBSD machine at home is also not up.)
>=20
> In Makefile.inc1 we have:
>=20
> .if defined(DB_FROM_SRC)
> INSTALLFLAGS+=3D -N ${.CURDIR}/etc
> MTREEFLAGS+=3D -N ${.CURDIR}/etc
> .endif
>=20
> which is fine as far as it goes, but then if ${LOCAL_MTREE} is defined we
> have this:
>=20
> .for _mtree in ${LOCAL_MTREE}
>         mtree -deU -f ${.CURDIR}/${_mtree} -p ${WORLDTMP} > /dev/null
> .endfor
>=20
> which omits the -N flag, even with DB_FROM_SRC set.  This means if a local
> mtree file "wants" user and/or group names that are not on your build
> system, but are in the new (but not yet installed anywhere) master.passwd
> and/or group files, the build fails when prepping the worldtmp area.  See=
ms
> like this should be "mtree ${MTREEFLAGS} ...", shouldn't it?

That seems correct to me.  I think I failed to add ${MTREEFLAGS} because
I didn't resolve how LOCAL_MTREE and master.passwd/group were going to
interact.

-- Brooks

--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTbddEACgkQXY6L6fI4GtR62ACfeiuDarg6pKo7Rj2fFRVB2Ot9
qKUAnRF3eU69+4VOg3n0p8MxcYw35vCO
=kASN
-----END PGP SIGNATURE-----

--yNb1oOkm5a9FJOVX--