From owner-svn-src-head@freebsd.org Sat May 19 10:42:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC0D2EF5EE7; Sat, 19 May 2018 10:42:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 229D76939F; Sat, 19 May 2018 10:42:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w4JAgaNO081348 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 19 May 2018 13:42:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w4JAgaNO081348 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w4JAga1u081347; Sat, 19 May 2018 13:42:36 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 19 May 2018 13:42:36 +0300 From: Konstantin Belousov To: Hans Petter Selasky Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333844 - head/sys/kern Message-ID: <20180519104236.GI6887@kib.kiev.ua> References: <201805190413.w4J4DLag027044@repo.freebsd.org> <1c2b35bf-4dbb-6aec-fdde-43f91edc8b69@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c2b35bf-4dbb-6aec-fdde-43f91edc8b69@selasky.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 10:42:47 -0000 On Sat, May 19, 2018 at 12:22:48PM +0200, Hans Petter Selasky wrote: > On 05/19/18 06:13, Matt Macy wrote: > > va_start(ap, fmt); > > - res = make_dev_credv(0, &dev, devsw, unit, cr, uid, gid, mode, fmt, ap); > > + DBGSET(res, make_dev_credv(0, &dev, devsw, unit, cr, uid, gid, mode, fmt, ap)); > > Is the make_dev_credv() called stubbed for non-debug builds? Apparently not. And my note about timer filter was also wrong. But this is indeed very unusual and error-prone macro, which seems to be removed in r333862.