From owner-p4-projects@FreeBSD.ORG  Mon Jul 17 20:39:21 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4C75F16A4F1; Mon, 17 Jul 2006 20:39:21 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CC14416A4E7;
	Mon, 17 Jul 2006 20:39:20 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1155043D49;
	Mon, 17 Jul 2006 20:39:18 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k6HKdHhM042217;
	Mon, 17 Jul 2006 16:39:18 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Mon, 17 Jul 2006 16:27:56 -0400
User-Agent: KMail/1.9.1
References: <200607171946.k6HJkFLs031826@repoman.freebsd.org>
In-Reply-To: <200607171946.k6HJkFLs031826@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607171627.56827.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 17 Jul 2006 16:39:18 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.87.1/1600/Sat Jul 15 11:03:46 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 101794 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Jul 2006 20:39:21 -0000

On Monday 17 July 2006 15:46, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101794
> 
> Change 101794 by piso@piso_newluxor on 2006/07/17 19:45:55
> 
> 	Obviously if we return different ORed values, we use &
> 	instead of == to check the return value.

I guess this fixes your problem. :)

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/kern/kern_intr.c#8 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/kern/kern_intr.c#8 (text+ko) ====
> 
> @@ -798,14 +798,14 @@
>  		}
>  
>  		/* Mark handler for later execution in ithread. */
> -		if (ret2 == FILTER_SCHEDULE_THREAD) {
> +		if (ret2 & FILTER_SCHEDULE_THREAD) {
>  			ih->ih_need = 1; 
>  			ret |= FILTER_SCHEDULE_THREAD;
>  			continue;
>  		}
>  
>  		/* Interrupt served in filter. */
> -		if (ret2 == FILTER_HANDLED) {
> +		if (ret2 & FILTER_HANDLED) {
>  			ret |= FILTER_HANDLED;
>  			return (ret);
>  		}
> 

-- 
John Baldwin