From nobody Fri Jul 24 11:12:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h651h2X23z6lhH6 for ; Fri, 24 Jul 2026 11:12:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h651g6RqSz4Nwf for ; Fri, 24 Jul 2026 11:12:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784891559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTCmIE1jbR0/5rQMOnr/QhXhdrj0jxegr9g6fbpmJxE=; b=K0TN1QKYmmQfZms/WO6PElTQe6npP/96if5vWzrYuTBY0Q8Ul3GtFrhNgCJi0xxc+ZM8jD 6qv1wjtYB1yzy2SxepUd+CANd+d75Mt8rtWoc/A+sA4+6xDeWGFGD7sM5iVVR1Pg0455ny Fps70lCzTtdPKOSrYWOZVZhGR3S+agOfcBOSNiSlHFwnHQHoCLjMKbFzX7ZYHjONJ8XAWS 7H/eQtSjIW24qgD6/TDjGE5GmRX3meembFEIZYz989Gn8gJrrtXyHP0z4PoRVGITBP0Tq4 NXco5Wzk7wXGjybG/DMSamZClL6YPr1r5ALRLWleF9ZrVsp5dSJkQemdANDKhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784891559; a=rsa-sha256; cv=none; b=vEFF/s8ATggkbqIuzgFTjn0X5OqsHpnOL5EOXmDYZMnxaDyz0dQRg9eCAC3xCORxrF1VIU CpSQa7B3s6H/zqti9bpXwQh0y66EHZj+SP5E2iSwkgVTxeIAW8MIZkosTPxKSJt1ERki3z 1zkTHT6fNUs7vAzHAh4L8u90GJwpveUl5/8SDre9TOHdSCR4oHuG+RF5MEy52YjbNaXSQK qLHCdl/Af85xcam9TxF3yPnaYq+kh0W6bGqV2/oJkjTJN5d4rHuWZdXyfDXHbdUS25XmKt 1Q9k+GA9mxpBsgg00JPYtLm45YL2EC5ps+gPg9bTDeEJmakGHNqo+Si4UE9SsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784891559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yTCmIE1jbR0/5rQMOnr/QhXhdrj0jxegr9g6fbpmJxE=; b=prxV1hxCT3CHMTRtJ9rVHPOaZv3QZU3dyw6I3fVnb8fQQK5xEkYXXzHc0d42yNS9CXboyS b3jU96ITqjWNvIrGPpgxw+qiN/FoxAbNIHbB7ZpSuont4G1x8V464kmmGL8lMjrkAy3iF7 4eNKQ+k66IVwmIxChcELUDFaLFiIpasg5jdJNbCmYBTTdI1e6F7XWyAw1W0BxReJaAuEbl L8gO3KyFCFgPgfuq4eKnBemyue98fFncpWaNWCD07MzEhI4zENuGMfC6nvbeuWNX9AGn7B 7qXGMk6ru9VcMbghIy/7LRWwdfz/WBMXYp6pF2y+yJ+0cgsnG+ynLKO0Cgt/AQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h651g5GPbzpbs for ; Fri, 24 Jul 2026 11:12:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 451b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Jul 2026 11:12:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: daf57eb11505 - main - icmp: Verify redirect gateway with fib-aware ifa selection List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: daf57eb115053613d01e338b9022db16c045f033 Auto-Submitted: auto-generated Date: Fri, 24 Jul 2026 11:12:34 +0000 Message-Id: <6a6348a2.451b1.11c16ef1@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=daf57eb115053613d01e338b9022db16c045f033 commit daf57eb115053613d01e338b9022db16c045f033 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-07-23 09:10:32 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-07-24 08:04:27 +0000 icmp: Verify redirect gateway with fib-aware ifa selection During call to `icmp_verify_redirect_gateway()` ensure using fib-aware source address selection function. Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D58409 --- sys/netinet/ip_icmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c index adf69c47aed5..fd1a3cd24c8f 100644 --- a/sys/netinet/ip_icmp.c +++ b/sys/netinet/ip_icmp.c @@ -965,8 +965,7 @@ icmp_verify_redirect_gateway(struct sockaddr_in *src, struct sockaddr_in *dst, if ((ifa = ifa_ifwithnet((struct sockaddr *)gateway, 0, fibnum))==NULL) return (ENETUNREACH); - /* TODO: fib-aware. */ - if (ifa_ifwithaddr_check((struct sockaddr *)gateway)) + if (ifa_ifwithaddr_fib_check((struct sockaddr *)gateway, fibnum)) return (EHOSTUNREACH); nh = fib4_lookup(fibnum, dst->sin_addr, 0, NHR_NONE, 0);