From owner-cvs-all  Tue Sep 14 22:11:27 1999
Delivered-To: cvs-all@freebsd.org
Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id 47664156FA; Tue, 14 Sep 1999 22:11:22 -0700 (PDT)
	(envelope-from peter@netplex.com.au)
Received: from netplex.com.au (localhost [127.0.0.1])
	by overcee.netplex.com.au (Postfix) with ESMTP
	id 58DC91CC4; Wed, 15 Sep 1999 13:11:21 +0800 (WST)
	(envelope-from peter@netplex.com.au)
X-Mailer: exmh version 2.0.2 2/24/98
To: obrien@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/contrib/cpio main.c 
In-reply-to: Your message of "Tue, 14 Sep 1999 21:37:59 MST."
             <19990914213758.A14707@dragon.nuxi.com> 
Date: Wed, 15 Sep 1999 13:11:21 +0800
From: Peter Wemm <peter@netplex.com.au>
Message-Id: <19990915051121.58DC91CC4@overcee.netplex.com.au>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

"David O'Brien" wrote:
> >     contrib/cpio         main.c 
> >   Log:
> >   Fix warning: return type of `main' is not `int'
> 
> I didn't think we made such changes in src/contrib/

Hmm.  Looking over what's written, the example of a 'trivial' change to be
avoided is "spelling fixes".  Compile warnings without -Wanything aren't
IMHO trivial.  Clobbering it to be -Wall safe wouldn't be a good thing
though.  (Which is why a WARNS variable default value needs to be
overrideable on a per directory basis)

Cheers,
-Peter



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message