Date: Wed, 30 Jul 2014 20:50:37 -0400 From: "Garance A Drosehn" <drosih@rpi.edu> To: "Alfred Perlstein" <alfred@freebsd.org> Cc: freebsd-arch@freebsd.org, phil@juniper.net, "Simon J. Gerraty" <sjg@juniper.net> Subject: Re: XML Output: libxo - provide single API to output TXT, XML, JSON and HTML Message-ID: <07923DF8-48CC-4A05-9260-529C51922DA7@rpi.edu> In-Reply-To: <53D944F5.7000207@freebsd.org> References: <20140725044921.9F0D3580A2@chaos.jnpr.net> <CAETOPp13H7kyLy-1VJRDOsDbOh8A1MWZDxw1xHUBsxTRtMfc7g@mail.gmail.com> <20140728054217.AC1A0580A2@chaos.jnpr.net> <20140728055336.GJ50802@ivaldir.etoilebsd.net> <CAETOPp3hJB8Gj%2BPMj3N951krnNqCYiAOY-cPHxMCBy1CQXWJaQ@mail.gmail.com> <A1E63A7A-BB38-4CC3-B5EC-B251BE990572@mail.turbofuzz.com> <20140729230345.31E9B580A2@chaos.jnpr.net> <53D85495.4050408@mu.org> <20140730053446.DCE8D580A2@chaos.jnpr.net> <53D944F5.7000207@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 Jul 2014, at 15:18, Alfred Perlstein wrote: > The goal of a GSOC project is to get the code into FreeBSD. > > The code can be seen here: > https://socsvn.freebsd.org/socsvn/soc2014/zkorchev/ > [...skip...] > The details for the code are here: > https://socsvn.freebsd.org/socsvn/soc2014/zkorchev/ > > You should be able to do an svn checkout and then get diffs > to see what is going on. If you require any assistance please > let me know. Those two URL's look extremely similar to me. Was the second one supposed to point to some other page? I haven't taken the time to check out the tree and skim through all the changes, but I looked at a few specific files. In .../lib/libsol/sol.c, it looks like the only format implemented so far is JSON. Is that true? Some dumb questions I should probably be able to figure out for myself: Where is SOL_JSON defined? sol.c includes sol.h, but sol.h does not seem to define that value. Also, sol.h includes yajl/yajl_gen.h, but I don't see where that file comes from. I looked at .../usr.bin/du/du.c just to see a simple example. I notice the '#if defined(SOL_ON)'. I assume that's just meant for the initial debugging, so that one could turn off all the SOL support if it was suspected of causing some problem. Is that expected to stay in the code once the code goes into production? If so, I'd rather see it as 'if (SOL_ON) { ... }', so that it's proper C code which the compiler would optimize away if SOL_ON was defined as FALSE. As a general rule I prefer to have the compiler *always* compiling&checking that code, even if some of it ends up producing no object code because SOL_ON is false. -- Garance Alistair Drosehn = drosih@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?07923DF8-48CC-4A05-9260-529C51922DA7>