From owner-freebsd-net@FreeBSD.ORG Fri Mar 29 15:45:36 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6C8BAB2D for ; Fri, 29 Mar 2013 15:45:36 +0000 (UTC) (envelope-from jeffrey.e.pieper@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx1.freebsd.org (Postfix) with ESMTP id 53AA8C11 for ; Fri, 29 Mar 2013 15:45:36 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 29 Mar 2013 08:45:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,373,1363158000"; d="scan'208";a="310328190" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2013 08:45:29 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.213]) by ORSMSX105.amr.corp.intel.com ([169.254.4.39]) with mapi id 14.01.0355.002; Fri, 29 Mar 2013 08:45:29 -0700 From: "Pieper, Jeffrey E" To: Barney Cordoba , Jack Vogel , Nick Rogers Subject: RE: igb and ALTQ in 9.1-rc3 Thread-Topic: igb and ALTQ in 9.1-rc3 Thread-Index: AQHOLBznR6O5n9a5ZEqL7qLIP4JHeJi9FUyA//+5EdA= Date: Fri, 29 Mar 2013 15:45:28 +0000 Message-ID: <2A35EA60C3C77D438915767F458D65687D46B19E@ORSMSX101.amr.corp.intel.com> References: <1364561471.47223.YahooMailClassic@web121602.mail.ne1.yahoo.com> In-Reply-To: <1364561471.47223.YahooMailClassic@web121602.mail.ne1.yahoo.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-net@freebsd.org" , "Clement Hermann \(nodens\)" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2013 15:45:36 -0000 -----Original Message----- From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org] = On Behalf Of Barney Cordoba Sent: Friday, March 29, 2013 5:51 AM To: Jack Vogel; Nick Rogers Cc: freebsd-net@freebsd.org; Clement Hermann (nodens) Subject: Re: igb and ALTQ in 9.1-rc3 --- On Thu, 3/28/13, Nick Rogers wrote: > From: Nick Rogers > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Jack Vogel" > Cc: "Barney Cordoba" , "Clement Hermann (nodens= )" , "freebsd-net@freebsd.org" > Date: Thursday, March 28, 2013, 9:29 PM > On Thu, Mar 28, 2013 at 4:16 PM, Jack > Vogel > wrote: > > Have been kept fairly busy with other matters, one > thing I could do short > > term is > > change the defines in igb the way I did in the em > driver so you could still > > define > > the older if_start entry. Right now those are based on > OS version and so you > > will > > automatically get if_transmit, but I could change it to > be IGB_LEGACY_TX or > > so, > > and that could be defined in the Makefile. > > > > Would this help? >=20 > I'm currently using ALTQ successfully with the em driver, so > if igb > behaved the same with respect to using if_start instead of > if_transmit > when ALTQ is in play, that would be great. I do not > completely > understand the change you propose as I am not very familiar > with the > driver internals. Any kind of patch or extra > Makefile/make.conf > definition that would allow me to build a 9-STABLE kernel > with an igb > driver that works again with ALTQ, ASAP, would be much > appreciated. >=20 > > > > Jack > > > > > > > > On Thu, Mar 28, 2013 at 2:31 PM, Nick Rogers > wrote: > >> > >> On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel > wrote: > >> > On Mon, Dec 10, 2012 at 11:58 PM, Gleb > Smirnoff > >> > wrote: > >> > > >> >> On Mon, Dec 10, 2012 at 03:31:19PM -0800, > Jack Vogel wrote: > >> >> J> UH, maybe asking the owner of the > driver would help :) > >> >> J> > >> >> J> ... and no, I've never been aware of > doing anything to stop > >> >> supporting > >> >> altq > >> >> J> so you wouldn't see any commits. If > there's something in the altq > >> >> code > >> >> or > >> >> J> support (which I have nothing to do > with) that caused this no-one > >> >> informed > >> >> J> me. > >> >> > >> >> Switching from if_start to if_transmit > effectively disables ALTQ > >> >> support. > >> >> > >> >> AFAIR, there is some magic implemented in > other drivers that makes them > >> >> modern (that means using if_transmit), but > still capable to switch to > >> >> queueing > >> >> mode if SIOCADDALTQ was casted upon them. > >> >> > >> >> > >> > Oh, hmmm, I'll look into the matter after my > vacation. > >> > > >> > Jack > >> > >> Has there been any progress on resolving this > issue? I recently ran > >> into this problem upgrading my servers from 8.3 to > 9.1-RELEASE and am > >> wondering what the latest recommendation is. I've > used ALTQ and igb > >> successfully for years and it is unfortunate it no > longer works. > >> Appreciate any advice. > >> > >Do yourself a favor and either get a cheap dual port 82571 card or >2 cards and disable the IGB ports. The igb driver is defective, and until >they back out the new, untested multi-queue stuff you're just neutering=20 >your system trying to use it. > >Frankly this project made a huge mistake by moving forward with multi >queue just for the sake of saying that you support it; without having >any credible plan for implementing it. That nonsense that Bill Macy did >should have been tarballed up and deposited in the trash folder. The >biggest mess in programming history. > >That being said, the solution is not to hack the igb driver; its to make >ALTQ if_transmit compatible, which shouldn't be all that difficult.=20 > >BC I may be misunderstanding what you are saying, but if the solution is, as y= ou say "not to hack the igb driver", then how is it defective in this case?= Or are you just directing vitriol toward Intel? Multi-queue is working fin= e in igb.=20 Jeff _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"