From owner-freebsd-audit  Fri Jun 22  9:32:32 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F99737B407; Fri, 22 Jun 2001 09:32:26 -0700 (PDT)
	(envelope-from mike@q9media.com)
Received: from [192.168.1.10] (vega.tct.net [216.94.230.13])
	by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f5MGirL85366;
	Fri, 22 Jun 2001 12:44:53 -0400 (EDT)
	(envelope-from mike@q9media.com)
User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022
Date: Fri, 22 Jun 2001 12:32:26 -0400
Subject: Re: whois(1) patch
From: Mike Barcroft <mike@q9media.com>
To: <obrien@freebsd.org>
Cc: Mike Heffner <mheffner@vt.edu>, <phk@freebsd.org>,
	<freebsd-audit@freebsd.org>
Message-ID: <B758EB5A.D6C%mike@q9media.com>
In-Reply-To: <20010622033201.B506@dragon.nuxi.com>
Mime-version: 1.0
Organization: q9 media
Content-type: text/plain; charset="US-ASCII"
Content-transfer-encoding: 7bit
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On 6/22/01 6:32 AM, David O'Brien at obrien@freebsd.org wrote:

> You should separate your patches into functionality and style(9).
> I see DES just committed this patch as is, rather than break it into two
> parts as our practices says it should have been.

Sorry.  I'll make sure I do this in future.

> You also changed puts() to printf().  Was there a reason for making that
> change?

style(9):
     Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually
     cleaner, not to mention avoiding stupid bugs.


Best regards,
Mike Barcroft


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message