From owner-freebsd-ports@FreeBSD.ORG  Tue Jun 27 14:37:00 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A5A916A400
	for <freebsd-ports@freebsd.org>; Tue, 27 Jun 2006 14:37:00 +0000 (UTC)
	(envelope-from tarc@tarc.po.cs.msu.su)
Received: from tarc.po.cs.msu.su (tarc.po.cs.msu.su [158.250.16.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C9BA43D80
	for <freebsd-ports@freebsd.org>; Tue, 27 Jun 2006 14:36:53 +0000 (GMT)
	(envelope-from tarc@tarc.po.cs.msu.su)
Received: from tarc.po.cs.msu.su (localhost [127.0.0.1])
	by tarc.po.cs.msu.su (8.13.4/8.13.4) with ESMTP id k5REbu2p083715
	for <freebsd-ports@freebsd.org>; Tue, 27 Jun 2006 18:37:56 +0400 (MSD)
	(envelope-from tarc@tarc.po.cs.msu.su)
Received: (from tarc@localhost)
	by tarc.po.cs.msu.su (8.13.4/8.13.4/Submit) id k5REbuNu083714
	for freebsd-ports@freebsd.org; Tue, 27 Jun 2006 18:37:56 +0400 (MSD)
	(envelope-from tarc)
Date: Tue, 27 Jun 2006 18:37:56 +0400
From: Arseny Nasokin <tarc@tarc.po.cs.msu.su>
To: freebsd-ports <freebsd-ports@freebsd.org>
Message-ID: <20060627143756.GS32801@tarc.po.cs.msu.su>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
User-Agent: mutt-ng/devel-r581 (FreeBSD)
Subject: HEADSUP: WITH and WITHOUT options knobs checking
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2006 14:37:00 -0000

It's wrong if you write in your Makefiles something about:
--------------%<----------------
...
OPTIONS= ABC "Enable abc feature" off 
...
.include <bsd.port.pre.mk>
...
.if defined (WITH_ABC)
# configure ABC feature
.endif
...
.include <bsd.port.post.mk>
------------->%-----------------

The main reason is that, ${OPTIONSFILE} included as is, and if you enable ABC(as in example), you have in ${OPTIONSFILE} something about:
--------------%<----------------
...
WITH_ABC=true
...
------------->%-----------------


Ok, and now some experiments.
If ABC is feature, that you want enable im many ports (for example, OPTIMIZED_FLAGS or THREADS, or ESOUND/ESD.....)
you possibly want add it to your /etc/make.conf file.

cat WITH_ABC=true >>  /etc/make.conf 

than, you want compile port, without this feature. You do `make config' and as result in your ${OPTIONSFILE} you have:
--------------%<----------------
...
WITHOUT_ABC=true
...
------------->%-----------------

And now - compile...

when you type `make build' you have defined BOTH `WITH_ABC' and `WITHOUT_ABC' knobs

and as you check _only_ WITH_ABC, this feature included. That's wrong!!!


Please, check WITH_ knobs, as it:
.if defined (WITH_ABC) && ! defined(WITHOUT_ABC)

-- 
   Best regards,
   	Arseny Nasokin