From owner-freebsd-current@freebsd.org Mon Dec 21 21:04:26 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4B3B4C4574 for ; Mon, 21 Dec 2020 21:04:26 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-ztdg10021901.me.com (pv50p00im-ztdg10021901.me.com [17.58.6.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D0BmS6PFyz4YM9 for ; Mon, 21 Dec 2020 21:04:24 +0000 (UTC) (envelope-from tsoome@me.com) Received: from nazgul.lan (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-ztdg10021901.me.com (Postfix) with ESMTPSA id 346908802FD; Mon, 21 Dec 2020 21:04:15 +0000 (UTC) From: Toomas Soome Message-Id: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: review request: loader: implement framebuffer console Date: Mon, 21 Dec 2020 23:04:12 +0200 In-Reply-To: Cc: FreeBSD Current To: Jan Beich References: X-Mailer: Apple Mail (2.3654.40.0.2.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-21_11:2020-12-21, 2020-12-21 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2012210143 X-Rspamd-Queue-Id: 4D0BmS6PFyz4YM9 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_FROM(0.00)[me.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:17.58.0.0/16]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[me.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[me.com,quarantine]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[17.58.6.55:from]; FREEMAIL_ENVFROM(0.00)[me.com]; ASN(0.00)[asn:714, ipnet:17.58.0.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[me.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[me.com:s=1a1hai]; FREEFALL_USER(0.00)[tsoome]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; SPAMHAUS_ZRD(0.00)[17.58.6.55:from:127.0.2.255]; RECEIVED_SPAMHAUS_PBL(0.00)[80.235.52.148:received]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 21:04:26 -0000 Hi! I=E2=80=99m sorry, the reponse too a bit:) I had to find and fix few = issues first and then we got git:D Anyhow, with git you can use git am to apply this diff: = http://148-52-235-80.sta.estpak.ee/0001-loader-implement-framebuffer-conso= le.patch = (phab is also updated). thanks, toomas > On 14. Dec 2020, at 16:03, Jan Beich wrote: >=20 > Jan Beich writes: >=20 >> Toomas Soome writes: >>=20 >>> hi! >>>=20 >>> I have been working on proper framebuffer support on FreeBSD loader >>> and there is the current state: https://reviews.freebsd.org/D27420 >>> >>>=20 >>> All feedback is welcome, and especially if you can spare some time = for testing:) >>=20 >> Do you have another source? Phabricator excludes some files e.g., >>=20 >> $ fetch 'https://reviews.freebsd.org/D27420?download=3Dtrue' | patch = -Efsp0 >> $ make -sj8 buildworld >> [...] >> =3D=3D=3D> stand/images (all) >> make[4]: make[4]: don't know how to make freebsd-brand-rev.png. Stop >=20 > FWIW, I've tried CLI but no joy: >=20 > $ svn status > $ pkg install arcanist-php80 > $ arc patch D27420 > PHP Deprecated: Function libxml_disable_entity_loader() is = deprecated in /usr/local/lib/php/arcanist/support/init/init-script.php = on line 92 >=20 > Deprecated: Function libxml_disable_entity_loader() is deprecated in = /usr/local/lib/php/arcanist/support/init/init-script.php on line 92 > [2020-12-14 13:42:12] EXCEPTION: (Exception) Error while loading file = "/usr/local/lib/php/arcanist/src/workflow/ArcanistWorkflow.php": Private = methods cannot be final as they are never overridden by other classes at = [/src/init/lib/PhutilBootloader.php:275] > arcanist() > #0 PhutilBootloader::executeInclude(string) called at = [/src/init/lib/PhutilBootloader.php:207] > #1 PhutilBootloader::loadLibrarySource(string, string) called at = [/src/symbols/PhutilSymbolLoader.php:422] > #2 PhutilSymbolLoader::loadSymbol(array) called at = [/src/symbols/PhutilSymbolLoader.php:277] > #3 PhutilSymbolLoader::selectAndLoadSymbols() called at = [/src/init/init-library.php:23] > #4 __phutil_autoload(string) > #5 class_exists(string) called at = [/src/symbols/PhutilClassMapQuery.php:216] > #6 PhutilClassMapQuery::loadMap() called at = [/src/symbols/PhutilClassMapQuery.php:184] > #7 PhutilClassMapQuery::execute() called at = [/src/runtime/ArcanistRuntime.php:535] > #8 ArcanistRuntime::newWorkflows(ArcanistArcToolset) called at = [/src/runtime/ArcanistRuntime.php:115] > #9 ArcanistRuntime::executeCore(array) called at = [/src/runtime/ArcanistRuntime.php:37] > #10 ArcanistRuntime::execute(array) called at = [/support/init/init-arcanist.php:6] > #11 require_once(string) called at [/bin/arc:10] >=20 > $ svn status > $ pkg install arcanist-php74 > $ arc patch D27420 > [...] > A (bin) stand/images/freebsd-logo-rev.png > A (bin) stand/images/freebsd-brand.png > A (bin) stand/images/freebsd-brand-rev.png > A stand/images/Makefile > svn: warning: W150002: 'stand/images' is already under version = control > svn: E200009: Could not add all targets because some targets are = already versioned > svn: E200009: Illegal target for the requested operation > A stand/i386/libi386/vbe.h > A stand/i386/libi386/vbe.c > A stand/fonts/Makefile > A stand/fonts/INDEX.fonts > svn: warning: W150002: 'stand/fonts' is already under version control > svn: E200009: Could not add all targets because some targets are = already versioned > svn: E200009: Illegal target for the requested operation > A stand/common/gfx_fb.h > A stand/common/gfx_fb.c > A contrib/terminus/ter-u32n.bdf > A contrib/terminus/ter-u32b.bdf > A contrib/terminus/ter-u28n.bdf > A contrib/terminus/ter-u28b.bdf > A contrib/terminus/ter-u24n.bdf > A contrib/terminus/ter-u24b.bdf > A contrib/terminus/ter-u22n.bdf > A contrib/terminus/ter-u22b.bdf > A contrib/terminus/ter-u20n.bdf > A contrib/terminus/ter-u20b.bdf > A contrib/terminus/ter-u18n.bdf > A contrib/terminus/ter-u18b.bdf > A contrib/terminus/ter-u16v.bdf > A contrib/terminus/ter-u16n.bdf > A contrib/terminus/ter-u16b.bdf > A contrib/terminus/ter-u14v.bdf > A contrib/terminus/ter-u14n.bdf > A contrib/terminus/ter-u14b.bdf > A contrib/terminus/ter-u12n.bdf > A contrib/terminus/ter-u12b.bdf > svn: warning: W150002: 'contrib/terminus' is already under version = control > svn: E200009: Could not add all targets because some targets are = already versioned > svn: E200009: Illegal target for the requested operation > A contrib/pnglite/pnglite.h > A contrib/pnglite/pnglite.c > A contrib/pnglite/README.md > A contrib/pnglite/LICENSE > svn: warning: W150002: 'contrib/pnglite' is already under version = control > svn: E200009: Could not add all targets because some targets are = already versioned > svn: E200009: Illegal target for the requested operation > svn: E125004: MIME type 'application/octet-stream > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E125004: MIME type 'application/octet-stream > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E125004: MIME type 'application/octet-stream > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/images/Makefile' > property 'svn:keywords' set on 'stand/images/Makefile' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/i386/libi386/vbe.h' > property 'svn:keywords' set on 'stand/i386/libi386/vbe.h' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/i386/libi386/vbe.c' > property 'svn:keywords' set on 'stand/i386/libi386/vbe.c' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/fonts/Makefile' > property 'svn:keywords' set on 'stand/fonts/Makefile' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/common/gfx_fb.h' > property 'svn:keywords' set on 'stand/common/gfx_fb.h' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'stand/common/gfx_fb.c' > property 'svn:keywords' set on 'stand/common/gfx_fb.c' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'contrib/pnglite/pnglite.h' > property 'svn:keywords' set on 'contrib/pnglite/pnglite.h' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > svn: E135001: Unrecognized line ending style 'native > \ No newline at end of property' for 'contrib/pnglite/pnglite.c' > property 'svn:keywords' set on 'contrib/pnglite/pnglite.c' > svn: E125004: MIME type 'text/plain > \ No newline at end of property' contains invalid character ' > ' in media type > OKAY Successfully applied patch to the working copy. >=20 > $ ls -l stand/images/*.png > -rw-r--r-- 1 foo foo 0 14 Dec 13:46 = stand/images/freebsd-brand-rev.png > -rw-r--r-- 1 foo foo 0 14 Dec 13:46 stand/images/freebsd-brand.png > -rw-r--r-- 1 foo foo 0 14 Dec 13:46 = stand/images/freebsd-logo-rev.png