From owner-p4-projects  Thu Jan 30 11:17:37 2003
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CA17437B405; Thu, 30 Jan 2003 11:17:35 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EC2937B401
	for <perforce@freebsd.org>; Thu, 30 Jan 2003 11:17:35 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 102E943F75
	for <perforce@freebsd.org>; Thu, 30 Jan 2003 11:17:35 -0800 (PST)
	(envelope-from green@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h0UJHYbv040506
	for <perforce@freebsd.org>; Thu, 30 Jan 2003 11:17:34 -0800 (PST)
	(envelope-from green@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h0UJHY01040503
	for perforce@freebsd.org; Thu, 30 Jan 2003 11:17:34 -0800 (PST)
Date: Thu, 30 Jan 2003 11:17:34 -0800 (PST)
Message-Id: <200301301917.h0UJHY01040503@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to green@freebsd.org using -f
From: Brian Feldman <green@FreeBSD.org>
Subject: PERFORCE change 24451 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=24451

Change 24451 by green@green_laptop_2 on 2003/01/30 11:16:41

	Calls to mac_prepare(3) could fail.

Affected files ...

.. //depot/projects/trustedbsd/sebsd/usr.bin/login/login.c#2 edit

Differences ...

==== //depot/projects/trustedbsd/sebsd/usr.bin/login/login.c#2 (text+ko) ====

@@ -522,8 +522,8 @@
 			bail(NO_SLEEP_EXIT, 1);
 		}
 		free(labeltext);
-		mac_prepare(&oldttylabel, "sebsd");
-		if (mac_get_file(ttyn, oldttylabel) != 0 ||
+		if (mac_prepare(&oldttylabel, "sebsd") != 0 ||
+		    mac_get_file(ttyn, oldttylabel) != 0 ||
 		    mac_to_text(oldttylabel, &oldttylabeltext) != 0) {
 			syslog(LOG_ERR, "Getting SEBSD label on terminal "
 			    "%s: %m", ttyn);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message