Date: Mon, 22 May 2023 12:42:39 +0200 From: Hans Petter Selasky <hselasky@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Jessica Clarke <jrtc27@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. Message-ID: <cca40908-db2c-747f-a988-88ca236d5ed9@freebsd.org> In-Reply-To: <CANCZdfrLXCOc%2Bxj0ycQURaSZvXj6ij3xe7oPABO9zvNvt7VTSg@mail.gmail.com> References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <e802dfc0-0a16-add1-cf5d-a8811b3bd3e6@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <ffb3f6ea-ef74-ebe3-884d-da567defd2e6@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <ac11ff8e-eeb9-a7e6-28d3-da5c9fad6567@freebsd.org> <A66F073E-06F4-4A91-82F3-01467D7A65BC@freebsd.org> <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org> <CANCZdfrLXCOc%2Bxj0ycQURaSZvXj6ij3xe7oPABO9zvNvt7VTSg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/22/23 01:01, Warner Losh wrote: > On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky <hselasky@freebsd.org> > wrote: > >> On 5/21/23 23:58, Jessica Clarke wrote: >>> What I disputed was your commit message, which at best is extremely >> misleading and at worst makes no sense, and the necessity of the change. >> >> Hi Jess, >> >> Your request for revert has been noted, but I see no urgency in such a >> revert. The code is perfectly fine either way. >> > > > Now is not the time for stubbornness. This change is easy to bring back in > if it proves to be what we want. Project custom dictates requests for back > out be given strong consideration unless there's a really compelling reason > why that's a bad idea. (And I don't see anything like that here). > > Just my suggestion... Hi Jess and Warner, Since the "stable/14" branch has not been made as it should, the 12th of May 2023, I'll revert this change, so it doesn't flow into there. Still, when commit messages are not clear, the FreeBSD way to handle that is by follow-up e-mails. Not so often I see people re-applying commits, because the commit message is wrong. As long as the code changes made er OK, the commit message is secondary. Honestly speaking, I see no code technical reason for immediate action on this issue. But I'll respect Jess's wish as a member of the FreeBSD team, even I don't agree about this decision. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cca40908-db2c-747f-a988-88ca236d5ed9>