From owner-freebsd-doc Tue Mar 4 2:43:37 2003 Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23B5737B401 for ; Tue, 4 Mar 2003 02:43:36 -0800 (PST) Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9]) by mx1.FreeBSD.org (Postfix) with SMTP id 3661643F75 for ; Tue, 4 Mar 2003 02:43:34 -0800 (PST) (envelope-from roam@ringlet.net) Received: (qmail 12655 invoked from network); 4 Mar 2003 10:39:22 -0000 Received: from office.sbnd.net (HELO straylight.ringlet.net) (217.75.140.130) by gandalf.online.bg with SMTP; 4 Mar 2003 10:39:22 -0000 Received: (qmail 9705 invoked by uid 1000); 4 Mar 2003 10:42:12 -0000 Date: Tue, 4 Mar 2003 12:42:11 +0200 From: Peter Pentchev To: Sean Chittenden Cc: freebsd-doc@FreeBSD.org Subject: Re: Update to the handbook (NSFBUFS)... Message-ID: <20030304104211.GI518@straylight.oblivion.bg> Mail-Followup-To: Sean Chittenden , freebsd-doc@FreeBSD.org References: <20030304000126.GV79234@perrin.int.nxad.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y96v7rNg6HAoELs5" Content-Disposition: inline In-Reply-To: <20030304000126.GV79234@perrin.int.nxad.com> User-Agent: Mutt/1.5.3i Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --y96v7rNg6HAoELs5 Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 03, 2003 at 04:01:26PM -0800, Sean Chittenden wrote: > Howdy. Much to my surprise, there's a lack of documentation on the > 'sfbufa' state and what it means. Hopefully Google will pick this up > and it'll make life easier for folks. There's a whitespace patch in > there as well. >=20 > http://people.freebsd.org/~seanc/patches/#handbook_nsfbufs_update >=20 > These look alright? -sc The whitespace patch looks great. For the NSFBUFS one, two comments. First, it may be better to use 'may' instead of 'will' in the section: if there are enough sf_buf structures, the sendfile(2) call will not block at all. Second, since you are rewriting the whole paragraph above (the one actually explaining what NSFBUFS is all about), it will be perfectly acceptable to introduce a whitespace change (or fix) there: change the leading spaces to tabs in all but the first line :) Good work! G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@sbnd.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 Nostalgia ain't what it used to be. --y96v7rNg6HAoELs5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+ZIMD7Ri2jRYZRVMRAnbqAKCzuTApzBWrgDjYBu9p6t8kS3cUjgCfcu/n s3blz+fhn1UFK4Aoc/IIMJg= =qWDR -----END PGP SIGNATURE----- --y96v7rNg6HAoELs5-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message