From owner-freebsd-hackers  Mon Nov  9 14:39:35 1998
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id OAA01442
          for freebsd-hackers-outgoing; Mon, 9 Nov 1998 14:39:35 -0800 (PST)
          (envelope-from owner-freebsd-hackers@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA01433
          for <freebsd-hackers@freefall.cdrom.com>; Mon, 9 Nov 1998 14:39:32 -0800 (PST)
          (envelope-from dan@dan.emsphone.com)
Received: from dan.emsphone.com (dan@dan.emsphone.com [199.67.51.101])
	by freefall.freebsd.org (8.8.8/8.8.5) with ESMTP id OAA06342
	for <freebsd-hackers@freefall.cdrom.com>; Mon, 9 Nov 1998 14:39:34 -0800 (PST)
Received: (from dan@localhost)
	by dan.emsphone.com (8.9.1/8.9.1) id QAA20818;
	Mon, 9 Nov 1998 16:38:54 -0600 (CST)
Date: Mon, 9 Nov 1998 16:38:53 -0600
From: Dan Nelson <dnelson@emsphone.com>
To: Mike Smith <mike@smith.net.au>
Cc: Thomas David Rivers <rivers@dignus.com>,
        freebsd-hackers@freefall.cdrom.com
Subject: Re: A stdio question... does fpos_t really need to be 'long long'?
Message-ID: <19981109163853.A20712@emsphone.com>
References: <19981109110955.A5248@emsphone.com> <199811092006.MAA00487@dingo.cdrom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.94.3i
In-Reply-To: <199811092006.MAA00487@dingo.cdrom.com>; from "Mike Smith" on Mon Nov  9 12:06:12 GMT 1998
X-OS: FreeBSD 2.2.7-STABLE
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In the last episode (Nov 09), Mike Smith said:
> Dan said:
> > I noticed this back in April and commented on it.  I believe the
> > consensus was that fsetpos()/fgetpos()/fseek()/ftell() should be
> > wrappers for the X/Open functions fseeko() and ftello(), which take
> > off_t arguments.
> > 
> > Unfortunately, I never submitted patches, and neither did anyone else.
> > 
> > 	-Dan Nelson
> > 	dnelson@emsphone.com
> > 
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-hackers" in the body of the message
> 
> So submit them, dammit!  8)

grumble grumble.. :)

Ok.  Could someone go over PR bin/8637 and tell me if it looks okay?
I've rebuilt libc on my machine and it seems to work; I can seek to the
end of a 5gb datafile and get my position correctly.

The only bad thing in my patch is the error you get if you ftell() on a
FILE* that is positioned past 2 gig.  errno.h doesn't have an
EOVERFLOW, which is what X/Open says ftell should return.  I put EFBIG
in instead.

Whoops.  Something I realize I forgot already is manpage tweaks to
document fseeko and ftello.

	-Dan Nelson
	dnelson@emsphone.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message