Date: Thu, 17 Sep 2009 02:24:48 +0200 From: Adrian Penisoara <ady@freebsd.ady.ro> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: guido@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management Message-ID: <78cb3d3f0909161724i4f4b7b3andcd9fed79ca32278@mail.gmail.com> In-Reply-To: <20090911154142.GF1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> <20090911154142.GF1673@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Fri, Sep 11, 2009 at 5:41 PM, Pawel Jakub Dawidek <pjd@freebsd.org> wrot= e: > On Fri, Sep 11, 2009 at 05:19:41PM +0200, Adrian Penisoara wrote: >> =A0Actually using /etc/fstab for zvol swap is not quite working in the >> current setup since /etc/rc.d/swap1 does not automatically swapoff >> upon shutdown which makes 'zvol stop' attempt to close the (swap) >> volume(s) while still in use. >> =A0 I guess 'zfs volfini' should be triggered by a shutdown hook >> similarly to what geom(4) classes are using. >> >> =A0I see Guido committed a swapoff hook in changeset 189624 (similar to >> what I suggested in my initial PR) but immediately backed it out the >> next day. Funny thing is that this swapoff hook flip-flopped over >> time, see changesets 135389, 137255. >> >> =A0Is there a reason not to have the swap devices automatically >> unmounted from /etc/swap1 upon shutdown ? > > The answer is simple: we don't want swapoff to fail. > > There really no point in removing swap on shutdown (it could still be a > good idea to do it when administrator executes /etc/rc.d/swap1 stop). > We unmount file systems on shutdown, because we want to keep them > consistent. There is no need to keep swap consistent, as the data will > be useless after reboot anyway. > > All in all running swapoff at shutdown time increases reboot time and > introduce possibility of failure (I think the kernel can panic if there > is no enough memory to move everything out of the swap, but I might be > wrong here). Some (if not most) of the Linux distros do turn off swap at shutdown time and AFAIK they did not encounter issues. One more white ball to do the same. > > There are some tricky cases too. For example: > > =A0 =A0 =A0 =A0# truncate -s 1g /swap.img > =A0 =A0 =A0 =A0# mdconfig -a -f /swap.img > =A0 =A0 =A0 =A0# swapon /dev/md0 > > Now if we don't remove swap we won't be able to unmount file system in > non-forcible way. Hmm, I guess we still need to "mdconfig -d" to have a clean filesystem unmount anyway... > >> > system to 'legacy' and then you can mount it from to /etc/fstab too. >> > >> >> =A0Perhaps not the best idea: what if I export and then import a zpool >> from one system to another -- then I will have some swap volumes >> automatically mounted upon boot, breaking POLA. >> >> =A0You can argue that ZFS filesystems will also be automatically mounted >> too, but this is a consistent behavior across different OSes while the >> discussed swap volume automount is FreeBSD specific. >> >> =A0Sorry to insist, but I still think we should we keep it simple... >> Unless people are already using/depending on this feature. > > Please understand that I don't want to disallow swap configuration from > /etc/fstab. I'm just giving an option. Sure. > > I'll think about it a bit more and talk to some people what they think > about this and I'll get back to you. Maybe this property is indeed > redundant, but I don't want to make any rush decisions. > OK, waiting your feedback. Thanks, Adrian Penisoara EnterpriseBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?78cb3d3f0909161724i4f4b7b3andcd9fed79ca32278>