From owner-cvs-src@FreeBSD.ORG Mon Oct 4 17:02:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F17416A4CF; Mon, 4 Oct 2004 17:02:43 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.176]) by mx1.FreeBSD.org (Postfix) with ESMTP id E82D643D1F; Mon, 4 Oct 2004 17:02:42 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CEWEU-0002lE-00; Mon, 04 Oct 2004 19:02:42 +0200 Received: from [217.83.8.81] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CEWET-0003PY-00; Mon, 04 Oct 2004 19:02:42 +0200 From: Max Laier To: Dag-Erling Smorgrav Date: Mon, 4 Oct 2004 19:01:55 +0200 User-Agent: KMail/1.7 References: <200410041126.i94BQ273055417@repoman.freebsd.org> <200410041351.13214.max@love2party.net> In-Reply-To: <200410041351.13214.max@love2party.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2354569.C1KItYeIlm"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200410041902.03817.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/rm rm.1 rm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2004 17:02:43 -0000 --nextPart2354569.C1KItYeIlm Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 04 October 2004 13:51, I wrote: > On Monday 04 October 2004 13:26, Dag-Erling Smorgrav wrote: > > des 2004-10-04 11:26:02 UTC > > > > FreeBSD src repository > > > > Modified files: > > bin/rm rm.1 rm.c > > Log: > > Find out how flame-proof my underwear really is. > > From the committer-guide: > "Good commit messages are important. They tell others why you did the > changes you did, not just right here and now, but months or years from now > when someone wonders why some seemingly illogical or inefficient piece of > code snuck into your source file." > > Other than that, this seems to be an outcome of the *ongoing* thread in > hackers. If there is any consensus in that thread, then it's that every > such goof should be conditionalized by a environment variable. > > Any particular reason for this change? Any added value in this warning (I > fail to see)? You never answered to this question. Neither on the list nor in your very r= ude=20 private mail. While it is true that this change does nothing bad, I still completely fail= to=20 see the point. I mean, hooray! you fixed one of a thousand ways to accident= ly=20 delete "/". Unfortunately it's seldom the obvious way that this happens.=20 Scripts might try to expand a variable that isn't there and do: rm -rf /${path}/ your "fix" won't help here. Or somebody types: rm -rf some_path /* ^ extra whitespace due to unfortunate use of tab-completion your "fix" doesn't help either. And so forth. So all the gain from this is= =20 added processing time, added code and an ego-boost for you (it seems to me). > > Revision Changes Path > > 1.30 +2 -1 src/bin/rm/rm.1 > > 1.49 +23 -0 src/bin/rm/rm.c =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2354569.C1KItYeIlm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBYYILXyyEoT62BG0RAjmoAJ9NI+poLn6bJhp8fJ75imJcNVHPWwCfWbSv rXB3KLE3CyL6juDCv+DEkak= =fQXB -----END PGP SIGNATURE----- --nextPart2354569.C1KItYeIlm--