From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 28 03:10:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7DA2D32E for ; Sat, 28 Sep 2013 03:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5E1DE2A97 for ; Sat, 28 Sep 2013 03:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8S3A00u071957 for ; Sat, 28 Sep 2013 03:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8S3A0Zc071956; Sat, 28 Sep 2013 03:10:00 GMT (envelope-from gnats) Resent-Date: Sat, 28 Sep 2013 03:10:00 GMT Resent-Message-Id: <201309280310.r8S3A0Zc071956@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kenji Rikitake Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7679B324 for ; Sat, 28 Sep 2013 03:08:57 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4B72C2A92 for ; Sat, 28 Sep 2013 03:08:57 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r8S38vO3041108 for ; Sat, 28 Sep 2013 03:08:57 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r8S38vhL041107; Sat, 28 Sep 2013 03:08:57 GMT (envelope-from nobody) Message-Id: <201309280308.r8S38vhL041107@oldred.freebsd.org> Date: Sat, 28 Sep 2013 03:08:57 GMT From: Kenji Rikitake To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/182453: Port databases/riak does not create the directory in /usr/local X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Sep 2013 03:10:00 -0000 >Number: 182453 >Category: ports >Synopsis: Port databases/riak does not create the directory in /usr/local >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Sep 28 03:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kenji Rikitake >Release: 9.2-PRERELEASE >Organization: >Environment: FreeBSD wellmax.priv.k2r.org 9.2-PRERELEASE FreeBSD 9.2-PRERELEASE #11 r255623: Tue Sep 17 17:02:32 JST 2013 root@wellmax.priv.k2r.org:/usr/obj/usr/src/sys/K2RKERNEL amd64 >Description: The Port creates the following three spurious directories /etc/riak /lib/riak/lib /lib/riak instead of /usr/local/etc/riak /usr/local/lib/riak/lib /usr/local/lib/riak during `make install`, and the install procedures abnormally terminated. My investigation suggests that the ".for" statement in the target "do-install" in the Makefile does not function properly. >How-To-Repeat: (cd /usr/ports/databases/riak && make && make install) >Fix: Apply the patch in this PR. (The .for loop in the Makefile is manually expanded; this patch will not add unnecessary complexity because the .for loop only handles five directories) Patch attached with submission follows: --- Makefile.orig 2013-09-27 21:04:42.000000000 +0900 +++ Makefile 2013-09-28 11:54:08.000000000 +0900 @@ -64,9 +64,11 @@ ${ECHO} "@dirrmtry %%RIAK_LOGDIR%%" >> ${PLIST} do-install: -.for d in ${RIAK_CONFDIR} ${RIAK_LOGDIR} ${RIAK_DBDIR} ${RIAK_LIBDIR} ${RIAK_HOMEDIR} - [ -d ${d} ] || ${MKDIR} ${d} && ${CHOWN} ${USERS}:${GROUPS} ${d} -.endfor + ${MKDIR} ${RIAK_CONFDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_CONFDIR} + ${MKDIR} ${RIAK_LOGDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_LOGDIR} + ${MKDIR} ${RIAK_DBDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_DBDIR} + ${MKDIR} ${RIAK_LIBDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_LIBDIR} + ${MKDIR} ${RIAK_HOMEDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_HOMEDIR} ${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/vm.args ${RIAK_CONFDIR}/vm.args.sample ${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/app.config ${RIAK_CONFDIR}/app.config.sample ${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/cert.pem ${RIAK_CONFDIR}/cert.pem.sample >Release-Note: >Audit-Trail: >Unformatted: