From nobody Sun Feb 15 15:56:21 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDVrV1fynz6RmNF for ; Sun, 15 Feb 2026 15:56:26 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDVrT0wzGz3hJl for ; Sun, 15 Feb 2026 15:56:25 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=F5v5jFEh; dmarc=pass (policy=none) header.from=gmail.com; arc=pass ("google.com:s=arc-20240605:i=1"); spf=pass (mx1.freebsd.org: domain of ahmadkhalifa570@gmail.com designates 2607:f8b0:4864:20::1135 as permitted sender) smtp.mailfrom=ahmadkhalifa570@gmail.com Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-7945838691aso57120637b3.0 for ; Sun, 15 Feb 2026 07:56:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771170982; cv=none; d=google.com; s=arc-20240605; b=bfa7XBmPg5XmQ+OB9Aui1ntzcqmGYPQqD1tf6W7QneDt3r1LynMQhIspHZgBFzvpSp zHw0jEItEq6SeAiLnCFhe+5Xfpl35dyA73s+nE0ZvXTxRxFDuXDRsDj+MeVEamOOiDcr ozcs1ABTbyBJKUtAY8wOAn/OUvQvhzCkqjx6SWSmeW0PkpPPLSHVseRPMVcWyd9X21ZZ XF6sxwKJQp72fKHnHeoNtJvXwIo8yo7NyUPsUnkIgP0e7ssnEsa1uU8na6tSO+h/WY7H /uMD3uQ9O2xpyLb7XvsVN0LmYQKDKUD1TN2aAhCMybbQiGLkb+84YvrK14GdXWnIfpPW K/HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:dkim-signature; bh=/99BRy876RnYDsqpxycBa1uqovz6g0buIhN09MjZebw=; fh=wY0QAskNAXMeRRln6kAOXFcrL8DnmCfc1sZ04xEecvg=; b=R3sQNroAKOqpUVVZuWGZ5lXMPYJIrx0O0NBAgr4vziRzxV2jZFiYlR+d/pvW0wMYa2 a3PwwnBBQMmgkoTNf0yUAAyF0uK0OvteoDDSLLg6O7n9/iSi2xqDS87bxaZAWoEFmrgp na/GmZZextDtf6PzkbrDPcNqICh65encPCcim73nSS3EpQRlmWIgV2WBD9UTEg0rhQ9i p4Nes8L7+EaD2GaO5MuDYfF3eNGttjQbGeisw5juSZEGqk6WwWXTGzFj13a9Qq210gm6 2L52vOcpCq0Fd+0XeYmHcjKhn1GV6vKGUJl1CattDdIJaUGOrTIyzMTpcv3bL7S3uHsF x0Wg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771170982; x=1771775782; darn=freebsd.org; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/99BRy876RnYDsqpxycBa1uqovz6g0buIhN09MjZebw=; b=F5v5jFEhoiyRNC24mWRjkNVe7vwFygB7AHhUwM6PGMRSio55Bz2Rpyx/N1L1HdTwvP xnp0KD57ew+iukkmwy2GArarl+LAeeM7x5inQ7L0/wA1DXmOEdfvUf+WWdIchdMRLGoi 5tAxWyZ7t+e09KEwr4LSEuEp6077OC8zrca2l9ZiXuO/6DTgBkD3pWdbFI1g8iN+Nq7L t5U5KsfJWVzu2DtonJrImWoVAGljuxd38oM3MdF8Qo1Kd7YaBAPnK2MPepiZ8Jf8BZuM /VCRt7WYfC9DTjJEuK6wByExVAu8h+eSbfwbhYfoxIujhvV4q2OyUhJ8cznQYjm2+c57 gM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771170982; x=1771775782; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/99BRy876RnYDsqpxycBa1uqovz6g0buIhN09MjZebw=; b=oRowaEKj9EC56v+duXeO1tDgx5ac4AudQa1ugMeUZJiShCAYvEAwc+k2l/5Eftmk3v cAZrLBJ2hPM5r2ScX0arOlioigh8KpfItHhDMgOsA0Hocqhbb4eDDbSBMXc7uUQsg9I8 MKyin+uboVGBX1pfb330uyinJ0BDbdjNQgcwowrxBi7zvhwNBTvIwO26jwslZpwIZwXs qBYylKArSMb0moeCjBXLkzh2wmiZqpaAbkF0QEoar7+Om/6GE0Cznmhb2uJtHTGapbxb huCqbTgy0woAnWmAAfZ9jrl5C90jgFR5MgFPkoPccvTQkwiyYhly4H3hRYqstCaWAeAE b/ow== X-Forwarded-Encrypted: i=1; AJvYcCXk9iZaU6+doeTglcIhM0G7brP5JSWPX7u7Gv+ThdEQQ5Xh09LuqDAxRefX8npH/TqauaQlSnRMmblE6Fm2AMpD0cENJQ==@freebsd.org X-Gm-Message-State: AOJu0YzedYunKW1ksvs7hfD2sEASzLsZfFj0oyzyNGIc8PbIlbNrnKdW jH+oNc08Boib2an7fPEOlz4XvMQY/M5j6lNqB68+Whj2JrYqxLXW4uSeifI8RhFESEYZLeLCJtV RYWjFih0951rPeojKL/UTFcinOUQVm8Y= X-Gm-Gg: AZuq6aLzF29C+gmNpVYOuKdqirBHuJnoKl7Uipukr2WCOtyj/k0pYQRDMqjjDz2h41x HWoqrnulefyVCvAqICtPFZ/pShxyL0Wi6IaMoJwK4C6iyrzhaGC1PHbnbANfo8FJuRMNcSesBKr JYw5K2u/MTs5r+rUTNORNKyrDcr0S36Zh7YTmdp1dhK8OptzyVHqvQVG4Uf4oFaXneDf2HqfXd7 velIN7vCGzOeSUAhURzcsmMAfecN2pQb59/1OBgRHhVGaTdNbT+MWNh4yelh8iVieRoak6DqulO WPXDW097 X-Received: by 2002:a05:690e:134c:b0:644:7b19:c207 with SMTP id 956f58d0204a3-64c202ba6ccmr4549512d50.38.1771170981852; Sun, 15 Feb 2026 07:56:21 -0800 (PST) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 07:56:21 -0800 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 07:56:21 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6991d07b.43f21.696cde4f@gitrepo.freebsd.org> <0B6A645E-D9E4-4337-B280-7E3CBA1FDC1B@freebsd.org> In-Reply-To: Date: Sun, 15 Feb 2026 07:56:21 -0800 X-Gm-Features: AaiRm53gWqqunYsX5ZPIGrM0_U1nrD5kRboJDntsJCJD_F7nPTjqVdI7zm61ym4 Message-ID: Subject: Re: git: a60e7e6ff0ec - main - stand: compile ia32 EFI loader with -malign-double To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-4.47 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.974]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1135:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4fDVrT0wzGz3hJl X-Spamd-Bar: ---- On Sun Feb 15, 2026 at 4:27 PM +0200, Ahmad Khalifa wrote: > On Sun Feb 15, 2026 at 4:02 PM +0200, Jessica Clarke wrote: >> On 15 Feb 2026, at 13:56, Ahmad Khalifa wrote: >>> >>> The branch main has been updated by vexeduxr: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >>> >>> commit a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >>> Author: Ahmad Khalifa >>> AuthorDate: 2026-02-15 12:23:26 +0000 >>> Commit: Ahmad Khalifa >>> CommitDate: 2026-02-15 13:30:06 +0000 >>> >>> stand: compile ia32 EFI loader with -malign-double >>> >>> The UEFI spec says: >>>> Structures are aligned on boundaries equal to the largest internal >>>> datum of the structure and internal data are implicitly padded to >>>> achieve natural alignment. >>> >>> By default, structs containing members of type "long long" have 4 byte >>> alignment on i386. This caused some EFI structures to be subtly wrong. >>> >>> Fix this by compiling the ia32 EFI loader with -malign-double, which >>> bumps the alignment up to 8 if such members are present. >> >> This seems like a dangerously big hammer. Are there any types shared >> with libsa or the kernel itself that would change layout? (I suppose >> for the latter they already need to be aligned as the kernel is 64-bit?) > > For the kernel, any shared types would have already needed to be > aligned, yes. I didn't consider shared types with either libsa or libefi > though, I'll look into it now. Nice catch. > Okay, so libsa, libefi, liblua and ficl all share types with the loader. Quite obvious in hindsight... I'll back this out until I come up with something better. >> >> Annotating just the EFI types would seem more appropriate, like how we >> annotate function pointers to use the Microsoft calling convention. > > They're all under contrib unfortunately. Not sure if we want to > introduce that big of a diff with upstream. > >> >> Jessica