From owner-freebsd-apache@freebsd.org Fri Mar 30 15:02:41 2018 Return-Path: Delivered-To: freebsd-apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E566AF73B41 for ; Fri, 30 Mar 2018 15:02:40 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7F0AD6C2E4 for ; Fri, 30 Mar 2018 15:02:40 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: by mailman.ysv.freebsd.org (Postfix) id 3EA0FF73B36; Fri, 30 Mar 2018 15:02:40 +0000 (UTC) Delivered-To: apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C67BF73B35 for ; Fri, 30 Mar 2018 15:02:40 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 831CF6C2E3 for ; Fri, 30 Mar 2018 15:02:39 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from [192.168.100.156] ([87.139.233.65]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M3i8r-1ekfe23Ddp-00rKyj for ; Fri, 30 Mar 2018 17:02:31 +0200 To: "apache@FreeBSD.org" From: olli hauer Subject: apache24 regression between svn r465240:465461 Openpgp: preference=signencrypt Message-ID: <1659d22a-0e5e-1dbf-5cd0-ec39d7bb3e55@gmx.de> Date: Fri, 30 Mar 2018 17:04:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:02YmMMnKqlJABEc43uG2OEUcfzEianiwVK9oxhltu2Z9ZDVogYZ HPTi4l7JrNuEeCYFbk/l/1UHDmD5J2fB9G8iTHC8ooJkyhi7xt+ULS/ShNPvumiRru96hsM Y9wOOOL+RStDeTZR1WU5eb+B1laLdnotAE68zCgQfMQSP53UNCKPig27hhyiDgyDTn9xIt6 QZeKYf9OSISyI5+GQFJLw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uvjMsNNOOuY=:KqLP5nEARk2EviEh9Os709 k+Ik0i5QOTShXTgxdM3MAuP05cX/jJMU3LhfAmnjx51azCkfNuw9U5SaajpUBwnheZMVhIS9t lRZuPfxruTGi2933aXiI96j8QadFfKrX/Gh3ANHVT3ajGqUMQEevQWQSN8JN1YOl8M9sPiEPo WAuYePehhwoVo4piuUXwG7L2VORgQ9NjH9NOi7cZncrbSUrhz0qmPuHg8R3YUb4UI74gZnNeV fMJwYF19MBv7ao5CRnNY/wA0Jl5PGT2iYQfxfmoD+PTS+1iwTD03k8zpVwK1cJSAjFtRf/3Sh qdzybDsXJdEWM1I8VzuDQwXEwaHL+XGelnG9luWRGtV7lAumPQ7FLbq4Eg/Bnk2YWgq6a5sXQ u5fhIGUXBFlbF7sfXzjO5VaxERv9qx4Bq/RxKWsXJb+if1ykHuLxUKzifxCDoxtfT4X85SWGM ZZ3XMc+NPdu3D0d8FS63aUoZ6yUWmjsrlh90/LyBdqiCAXULn0X7cpPARHY2+kwL1GPrTgg/D jnEwXa1DTAVw8baGdaIIjtyGK9EqyzGCvpAFB1QH2y+tlEyv1budmLf/WchXDDxWr3sNy3LeF 8XDSPjzmrs5rGlGn61/CN+u7fEFXbSDSmzVrKM+uvHuIpSZUVEQb91Kq+93FtzP3cSoTgYqCH 3ViT5p5aIecb3HiLkP1Ylpxhsmw3slXXYlwj3BO3tLbNa64AD/byMmLEiwmYpqonRgLiOosEI Ph86+twgdVNryxkWiu0bpAjH48NZ0Pj83aIW7uql7YKhKCDb+DufnrapuTE8twR1HtVtbHtsx E2d5eTiZyVglfAlCUJWOBglqcwfC7CT6u1pmP2rrxolGHGaQDc= X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:02:41 -0000 Seems there is a regression in the apache24 port between svn r465240:465461 With the change in Makfile.options from ALL_MODULES_CATEGORIES to ALL_MODULES it is no longer possible to build static modules since the code in Mk/Uses/apache.mk is no longer honored. That's the part in apache.mk .for category in ${ALL_MODULES_CATEGORIES} AVAILABLE_MODULES+= ${${category}_MODULES} .endfor ... .for module in ${AVAILABLE_MODULES} . if !empty(WITH_STATIC_MODULES:M${module}) CONFIGURE_ARGS+= --enable-${module:tl}=static PLIST_SUB+= MOD_${module}="@comment " . elif !empty(APACHE_MODULES:M${module}) CONFIGURE_ARGS+= --enable-${module:tl}=shared PLIST_SUB+= MOD_${module}="" . else CONFIGURE_ARGS+= --disable-${module:tl} PLIST_SUB+= MOD_${module}="@comment " . endif .endfor that was replaced with this simpler part in the ports Makefile .for module in ${ALL_MODULES} .if ${PORT_OPTIONS:M${module}} CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl} .else CONFIGURE_ARGS+= --disable-${module:S/_/-/g:tl} .endif .endfor That's OK, after the removal of apache22 large (server) parts of apache.mk can be removed if we do not support static modules any longer. But there is another regression that will be noticed only with the original apache24 httpd.conf the first time apache24 starts. httpd: Syntax error on line 143 of /usr/local/etc/apache24/httpd.conf: Cannot load libexec/apache24/mod_session_cookie.so into server: /usr/local/libexec/apache24/mod_session_cookie.so: Undefined symbol "ap_hook_session_save" This error message has is the result of three modules (session_cookie_module, session_crypto_module and session_dbd_module) that are enabled in httpd.conf without enabling session_module. One easy fix (dynamic modules only) could be: Index: apache24/Makefile =================================================================== --- apache24/Makefile (revision 465976) +++ apache24/Makefile (working copy) @@ -132,7 +132,7 @@ .for module in ${ALL_MODULES} .if ${PORT_OPTIONS:M${module}} -CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl} +CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl}=shared .else CONFIGURE_ARGS+= --disable-${module:S/_/-/g:tl} .endif The difference can be shown without installing apache by comparing httpd.conf.sample in the stage dir with and without the small patch. I know ./configure ---help does not show the usage of --enable-$module=(shared|static|yes), but this hint can be found in acinclude.m4 and as I remember in older apache versions -- olli