From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Mar 22 02:20:08 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22D3216A426 for ; Wed, 22 Mar 2006 02:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2373743D49 for ; Wed, 22 Mar 2006 02:20:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2M2K6Xq054064 for ; Wed, 22 Mar 2006 02:20:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2M2K6LU054059; Wed, 22 Mar 2006 02:20:06 GMT (envelope-from gnats) Resent-Date: Wed, 22 Mar 2006 02:20:06 GMT Resent-Message-Id: <200603220220.k2M2K6LU054059@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tai-hwa Liang Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBA1C16A41F for ; Wed, 22 Mar 2006 02:13:19 +0000 (UTC) (envelope-from avatar@www.mmlab.cse.yzu.edu.tw) Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw [140.138.150.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4256E43D66 for ; Wed, 22 Mar 2006 02:13:15 +0000 (GMT) (envelope-from avatar@www.mmlab.cse.yzu.edu.tw) Received: by www.mmlab.cse.yzu.edu.tw (qmail, from userid 1000) id 5B9608C9CF1; Wed, 22 Mar 2006 10:13:14 +0800 (CST) Message-Id: <20060322021314.5B9608C9CF1@www.mmlab.cse.yzu.edu.tw> Date: Wed, 22 Mar 2006 10:13:14 +0800 (CST) From: Tai-hwa Liang To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/94818: /etc/rc.subr:1.43 breaks /usr/local/etc/rc.d/samba.sh restart X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tai-hwa Liang List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2006 02:20:08 -0000 >Number: 94818 >Category: ports >Synopsis: /etc/rc.subr:1.43 breaks /usr/local/etc/rc.d/samba.sh restart >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 22 02:20:06 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Tai-hwa Liang >Release: FreeBSD 4.11-STABLE i386 >Organization: >Environment: System: FreeBSD 6.1-PRERELEASE System: FreeBSD 7.0-CURRENT >Description: Since /etc/rc.subr:1.43, /usr/local/etc/rc.d/samba.sh no longer can restart all daemons properly. >How-To-Repeat: Vanilla samba.sh from ports with latest /etc/rc.subr: # /usr/local/etc/rc.d/samba.sh restart Stopping /usr/local/sbin/nmbd. Starting SAMBA: removing stale tdbs : /var/db/samba/messages.tdb Starting nmbd. With patched samba.sh: # /usr/local/etc/rc.d/samba.sh restart Stopping /usr/local/sbin/nmbd. Starting SAMBA: removing stale tdbs : /var/db/samba/connections.tdb /var/db/samba/locking.tdb /var/db/samba/messages.tdb /var/db/samba/sessionid.tdb /var/db/samba/brlock.tdb Starting nmbd. Stopping /usr/local/sbin/smbd. Starting smbd. >Fix: Following workaround has been tested on RELENG_6 and HEAD. Please check and commit it, thanks. Index: samba.sh.sample =================================================================== RCS file: /home/ncvs/ports/net/samba3/files/samba.sh.sample,v retrieving revision 1.12 diff -u -p -r1.12 samba.sh.sample --- samba.sh.sample 9 Jan 2006 16:45:33 -0000 1.12 +++ samba.sh.sample 22 Mar 2006 01:51:58 -0000 @@ -88,6 +88,7 @@ command_args="-s ${samba_config}" load_rc_config $name run_rc_command "$1" +_rc_restart_done=false # smbd name=smbd @@ -103,6 +104,7 @@ command_args="-s ${samba_config}" load_rc_config $name run_rc_command "$1" +_rc_restart_done=false %%WINBIND%% %%WINBIND%%# winbindd %%WINBIND%%name=winbindd >Release-Note: >Audit-Trail: >Unformatted: