From owner-dev-commits-src-all@freebsd.org Mon Jan 4 21:10:02 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0CA5A4CD01D; Mon, 4 Jan 2021 21:10:02 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D8pDT3By7z4W8B; Mon, 4 Jan 2021 21:10:01 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1609794599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8PiDbFnctuicHieGmr8q7sdwe2gmaSbDX8BEFl5F89Q=; b=lSOoSMMtNjYVOna2qEB3OVY0LsejgBD2infguO+NGRI05nlUh11RfMlYwUzLNd+bKoNTrJ If9TBtyEnI07SqPjnDkl5T99kKeUiOsOULapktm32OSSK7wV0VDv1INJSwy/67ac8C18PJ REmpnQ12dtt/zChvvwQvXBAhxae7Jgk= Received: from amy.home (lfbn-idf2-1-745-114.w86-247.abo.wanadoo.fr [86.247.192.114]) by mx.blih.net (OpenSMTPD) with ESMTPSA id c1a4770c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 4 Jan 2021 21:09:59 +0000 (UTC) Date: Mon, 4 Jan 2021 22:09:59 +0100 From: Emmanuel Vadot To: rgrimes@freebsd.org Cc: "Rodney W. Grimes" , Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package Message-Id: <20210104220959.fb00d9ec75b43c3ed580ae37@bidouilliste.com> In-Reply-To: <202101042058.104Kwwhx004966@gndrsh.dnsmgr.net> References: <20210104215208.d02e08a9ef9fdd0387287784@bidouilliste.com> <202101042058.104Kwwhx004966@gndrsh.dnsmgr.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4D8pDT3By7z4W8B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 21:10:02 -0000 On Mon, 4 Jan 2021 12:58:58 -0800 (PST) "Rodney W. Grimes" wrote: > > On Mon, 4 Jan 2021 12:49:19 -0800 (PST) > > "Rodney W. Grimes" wrote: > > > > > > The branch main has been updated by manu: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > > > commit 2d486ba15f3367072d631ee588192ef46687fa4b > > > > Author: Emmanuel Vadot > > > > AuthorDate: 2020-12-21 15:00:02 +0000 > > > > Commit: Emmanuel Vadot > > > > CommitDate: 2021-01-04 15:17:12 +0000 > > > > > > > > pkgbase: Move bectl to the runtime package > > > > > > > > runtime contain what is needed to boot in single user and repair a > > > > system, bectl could be handy to have in this situation. > > > > > > I would think it belongs in the zfs package, > > > as unless you have zfs you do not need bectrl. > > > > There is no zfs package. > > I would consider that an oversight. I don't. We don't have a ufs package for example. > > Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related > > to pkgbase. > > WITH/WITHOUT are compile time constructs, pkgbase is an install time > set of tools, why can there not be a zfs pkg? pkgbase is just a reflection of what is built. There can be a zfs package nothing prevent us for having one. But as said in the commit runtime is the package that should contain everything needed for booting to single user and repair a system so it contain zfs related tools (and ufs ones). The idea behind runtime is that if you start upgrading and things break just after it you have all the tools to repair an install. > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D27708 > > > > --- > > > > lib/libbe/Makefile | 1 + > > > > sbin/bectl/Makefile | 1 + > > > > 2 files changed, 2 insertions(+) > > > > > > > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile > > > > index 291e2438ee2a..d1fab41578bf 100644 > > > > --- a/lib/libbe/Makefile > > > > +++ b/lib/libbe/Makefile > > > > @@ -4,6 +4,7 @@ SHLIBDIR?= /lib > > > > > > > > .include > > > > > > > > +PACKAGE= runtime > > > > LIB= be > > > > SHLIB_MAJOR= 1 > > > > SHLIB_MINOR= 0 > > > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile > > > > index 6fa84f48661d..46d43306b9ca 100644 > > > > --- a/sbin/bectl/Makefile > > > > +++ b/sbin/bectl/Makefile > > > > @@ -2,6 +2,7 @@ > > > > > > > > .include > > > > > > > > +PACKAGE=runtime > > > > PROG= bectl > > > > MAN= bectl.8 > > > > > > > > > > > > > > -- > > > Rod Grimes rgrimes@freebsd.org > > > > > > -- > > Emmanuel Vadot > > > > -- > Rod Grimes rgrimes@freebsd.org -- Emmanuel Vadot