From owner-svn-ports-all@freebsd.org  Thu Mar 31 15:56:51 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB7A2AE3519;
 Thu, 31 Mar 2016 15:56:51 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F4F11FCC;
 Thu, 31 Mar 2016 15:56:50 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id b392a694
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 31 Mar 2016 09:56:45 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r411158 - in head/net: . socketw
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20160331153705.GA47404@FreeBSD.org>
Date: Thu, 31 Mar 2016 09:56:44 -0600
Cc: Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <0955EF02-C11A-4C7B-A5E4-84065EC8A3FD@adamw.org>
References: <201603151249.u2FCnBCu021587@repo.freebsd.org>
 <20160331150243.GA29515@FreeBSD.org>
 <1459437572.1257749.564801874.0692E203@webmail.messagingengine.com>
 <20160331153705.GA47404@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2016 15:56:51 -0000

> On 31 Mar, 2016, at 9:37, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> 
> On Thu, Mar 31, 2016 at 10:19:32AM -0500, Mark Felder wrote:
>> On Thu, Mar 31, 2016, at 10:02, Alexey Dokuchaev wrote:
>>> On Tue, Mar 15, 2016 at 12:49:11PM +0000, Mark Felder wrote:
>>>> New Revision: 411158
>>>> URL: https://svnweb.freebsd.org/changeset/ports/411158
>>>> 
>>>> [...]
>>>> +MAINTAINER=	monwarez@mailoo.org
>>>> +COMMENT=	SocketW is a cross platform streaming socket C++
>>> 
>>> Violation of Section 5.6 of the PHB (clause #2).
>> 
>> Thanks, I'll correct that COMMENT ...
> 
> It probably does not warrant a dedicated commit, you might want to hold
> it off until more substantial changes arrive.  I sometimes have to wait
> years before fixing these types of mistakes because of lack of occasion.
> 
> ./danfe

Is a fix still a fix if it never gets committed?

# Adam


-- 
Adam Weinberger
adamw@adamw.org
http://www.adamw.org