From owner-freebsd-net@FreeBSD.ORG Fri Nov 14 11:57:20 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A58D71AF; Fri, 14 Nov 2014 11:57:20 +0000 (UTC) Received: from mail-pd0-x22b.google.com (mail-pd0-x22b.google.com [IPv6:2607:f8b0:400e:c02::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B50AAF7; Fri, 14 Nov 2014 11:57:20 +0000 (UTC) Received: by mail-pd0-f171.google.com with SMTP id r10so16610539pdi.30 for ; Fri, 14 Nov 2014 03:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Z5hSeA4uiIDAQTvbBSZV1BFvEAkIXKm57wtpl+scDa0=; b=DEgkEGMX52pKynf+QiY988IEnrLAHbOnUx8dIUYW5Y0gqqgj25J5N3v2nzYXd2aq2n 0UifkBYFmfAQxTUQV7kwff1i3dJXfJOrdbbhKypOkkFXXHzXKRoJEA/mD42wlqOv7AR4 7a8OG9G3XPzF2kyHk4ySx4h7ReQEcImOVd5iHiH09OdjIGLnqxiIrFgpTy+np6jSFast WFcvzTBbA/MG2C3Bcdz5tVCUPNTN8NydlawKJ7b7xQ9jQ9GSc9cAlSEFCOgQEZSUzK6J dZW1ya3hdJEl7j9wRotitlqvtSuAY2V3V8Ptd9wcouxLX0I2gkOF7c/VX3zEd0ly7b1H E74g== MIME-Version: 1.0 X-Received: by 10.68.68.240 with SMTP id z16mr9624677pbt.70.1415966240025; Fri, 14 Nov 2014 03:57:20 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.70.73.2 with HTTP; Fri, 14 Nov 2014 03:57:19 -0800 (PST) In-Reply-To: <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de> References: <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de> Date: Fri, 14 Nov 2014 12:57:19 +0100 X-Google-Sender-Auth: bHDfgzl280RyWYloSRkyZ4_5K3c Message-ID: Subject: Re: Checksumming outgoing packets in PF vs in ip[6]_output From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: Ilya Bakulin Content-Type: multipart/mixed; boundary=001a113817fcc0512c0507d054a5 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Freebsd hackers list , freebsd-net , J David , owner-freebsd-net@freebsd.org, "freebsd-pf@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 11:57:20 -0000 --001a113817fcc0512c0507d054a5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Here is a direct patch. Give it a try. For the reply-to issues there is another patch complementary to this i will send. On Fri, Nov 14, 2014 at 11:34 AM, Ilya Bakulin wrote: > Hi all, > > actually with _my_ checksumming patch the rdr-to is broken completely :-( > So I'm waiting for Ermal to send an updated version of his patch that may > really solve the problem! > > > On 2014-11-14 09:17, Ermal Lu=C3=A7i wrote: > >> Yes confirmed it will solve that issue as well. >> >> On Thu, Nov 13, 2014 at 9:30 PM, J David wrote= : >> >> On Wed, Nov 5, 2014 at 9:28 AM, Ilya Bakulin wrote: >>> > Of course it was interesting what does the upstream PF do (@ OpenBSD)= . >>> Seems >>> > they have made the decision to >>> > leave the task of recalculating the checksums for outgoing packets to >>> > ip[6]_output, because currently >>> > the code there overwrites the checksum anyway. >>> > This seems a correct way to me. pf should not longer do any checksum >>> updates >>> > in inbound and outbound path. >>> >>> Is there any chance this change would help with bug 179392 as well? >>> >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D179392 >>> >>> Or is that a separate issue? >>> >>> Thanks! >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >>> >>> > --=20 Ermal --001a113817fcc0512c0507d054a5 Content-Type: application/octet-stream; name="pf_ipv6_checksum.patch" Content-Disposition: attachment; filename="pf_ipv6_checksum.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2hhqx000 ZGlmZiAtLWdpdCBhL3N5cy9uZXRwZmlsL3BmL3BmX2lvY3RsLmMgYi9zeXMvbmV0cGZpbC9wZi9w Zl9pb2N0bC5jCmluZGV4IGRiYTU2NzQuLmNhN2Y4NTEgMTAwNjQ0Ci0tLSBhL3N5cy9uZXRwZmls L3BmL3BmX2lvY3RsLmMKKysrIGIvc3lzL25ldHBmaWwvcGYvcGZfaW9jdGwuYwpAQCAtNzYsNiAr NzYsNyBAQCBfX0ZCU0RJRCgiJEZyZWVCU0QkIik7CiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgog I2luY2x1ZGUgPG5ldGluZXQvaXAuaD4KICNpbmNsdWRlIDxuZXRpbmV0L2lwX3Zhci5oPgorI2lu Y2x1ZGUgPG5ldGluZXQ2L2lwNl92YXIuaD4KICNpbmNsdWRlIDxuZXRpbmV0L2lwX2ljbXAuaD4K IAogI2lmZGVmIElORVQ2CkBAIC0zNjE5LDEyICszNjIwLDkgQEAgcGZfY2hlY2s2X291dCh2b2lk ICphcmcsIHN0cnVjdCBtYnVmICoqbSwgc3RydWN0IGlmbmV0ICppZnAsIGludCBkaXIsCiAJaW50 IGNoazsKIAogCS8qIFdlIG5lZWQgYSBwcm9wZXIgQ1NVTSBiZWZvcmUgd2Ugc3RhcnQgKHMuIE9w ZW5CU0QgaXBfb3V0cHV0KSAqLwotCWlmICgoKm0pLT5tX3BrdGhkci5jc3VtX2ZsYWdzICYgQ1NV TV9ERUxBWV9EQVRBKSB7Ci0jaWZkZWYgSU5FVAotCQkvKiBYWFgtQlogY29weSZwYXN0ZSBlcnJv ciBmcm9tIHIxMjYyNjE/ICovCi0JCWluX2RlbGF5ZWRfY2tzdW0oKm0pOwotI2VuZGlmCi0JCSgq bSktPm1fcGt0aGRyLmNzdW1fZmxhZ3MgJj0gfkNTVU1fREVMQVlfREFUQTsKKwlpZiAoKCptKS0+ bV9wa3RoZHIuY3N1bV9mbGFncyAmIENTVU1fREVMQVlfREFUQV9JUFY2KSB7CisJCWluNl9kZWxh eWVkX2Nrc3VtKCptLCAoKm0pLT5tX3BrdGhkci5sZW4gLSBzaXplb2Yoc3RydWN0IGlwNl9oZHIp LCBzaXplb2Yoc3RydWN0IGlwNl9oZHIpKTsKKwkJKCptKS0+bV9wa3RoZHIuY3N1bV9mbGFncyAm PSB+Q1NVTV9ERUxBWV9EQVRBX0lQVjY7CiAJfQogCUNVUlZORVRfU0VUKGlmcC0+aWZfdm5ldCk7 CiAJY2hrID0gcGZfdGVzdDYoUEZfT1VULCBpZnAsIG0sIGlucCk7Cg== --001a113817fcc0512c0507d054a5--