From owner-freebsd-ipfw@FreeBSD.ORG Thu Dec 9 21:50:34 2004 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E366C16A4CE for ; Thu, 9 Dec 2004 21:50:34 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73FAE43D41 for ; Thu, 9 Dec 2004 21:50:34 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id iB9LrJPq015744; Thu, 9 Dec 2004 13:53:19 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id iB9LrJn6015743; Thu, 9 Dec 2004 13:53:19 -0800 Date: Thu, 9 Dec 2004 13:53:19 -0800 From: Brooks Davis To: Luigi Rizzo Message-ID: <20041209215319.GA12303@odin.ac.hmc.edu> References: <20041129192514.GA7331@odin.ac.hmc.edu> <20041130041932.B91746@xorpc.icir.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <20041130041932.B91746@xorpc.icir.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: Brooks Davis cc: ipfw@freebsd.org Subject: Re: strncmp usage in ipfw X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2004 21:50:35 -0000 --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 30, 2004 at 04:19:32AM -0800, Luigi Rizzo wrote: > i believe the original, old ipfw code used strncmp() to allow for > abbreviations. When i rewrote ipfw2 i did not feel like removing > the feature for fear of introducing backward compatibility problems > with existing files. However I agree that this introduces a > maintainability nightmare and i believe we should move to strcmp(), > especially given that with ipfw2 new option names are coming out > quite frequently. OK, that makes sense. I'd like to propose the following plan: - Disallow new strncmp instances in all branches. - remove strncmp usage in HEAD with the intention of explicitly adding back needed abbreviations when those abbreviations are both: - sane (no single letter appreviations, reasionable edit distance from other options, either obvious shorthand or reasionbly mnemonic). - actually used be someone (this is key, espeicaly since there are hundreds of possiable values and this isn't a documented feature as far as I can tell.) If need be we could implement a more complex stratigy for deprecation where we use a new matching function and warn about short matches, but I'm not sure that's necessicary. -- Brooks --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBuMlOXY6L6fI4GtQRAn4VAKC9ifH3iQJ9lhQnL/vuZahFrT/iMACeN73J /KIHi8HQOZClfeuTLcM7MMY= =jg7M -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--