From owner-freebsd-current Sun Oct 6 21:15:32 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10FE837B401 for ; Sun, 6 Oct 2002 21:15:31 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id E52D043E75 for ; Sun, 6 Oct 2002 21:15:29 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA21106; Mon, 7 Oct 2002 14:15:22 +1000 Date: Mon, 7 Oct 2002 14:25:16 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: freebsd-current@FreeBSD.ORG Cc: Michael Class Subject: Re: GEOM and SCSI-cd: mount not working any more In-Reply-To: <20021006194948.GA70043@dragon.nuxi.com> Message-ID: <20021007141632.Q27751-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 6 Oct 2002, David O'Brien wrote: > On Sun, Oct 06, 2002 at 06:20:12PM +0200, Poul-Henning Kamp wrote: > > Can I get you to insert printfs like the one below all places > > in vfs_mount.c and cd9660_vfsops.c where you see it using EINVAL > > and try to find out which particular one it is ? > > > > printf("EINVAL HERE %s %d\n", __FILE__, __LINE__): > > printf("EINVAL HERE %s %s %d\n", __func__, __FILE__, __LINE__); > > even, since we do have C99 in -current. :-) Or printf("foo 1\n"); printf("foo 2"\n); ... Using lots of __func, __FILE__, __LINE bloats the source and executable without significantly simplifying debugging, since unique strings are easy to find using grep. I'd like some of the standard bulky debugging interfaces to use the caller's pc and not pass around __func__, __FILE__, __LINE__. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message