From owner-svn-src-all@FreeBSD.ORG  Fri Jun 21 02:15:28 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 0909B7E7;
 Fri, 21 Jun 2013 02:15:28 +0000 (UTC)
 (envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
 by mx1.freebsd.org (Postfix) with ESMTP id C444A12E9;
 Fri, 21 Jun 2013 02:15:27 +0000 (UTC)
Received: from lstewart.caia.swin.edu.au (lstewart.caia.swin.edu.au
 [136.186.229.95])
 by lauren.room52.net (Postfix) with ESMTPSA id 02C977E81E;
 Fri, 21 Jun 2013 12:15:24 +1000 (EST)
Message-ID: <51C3B73C.70900@freebsd.org>
Date: Fri, 21 Jun 2013 12:15:24 +1000
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130521 Thunderbird/17.0.6
MIME-Version: 1.0
To: Konstantin Belousov <kib@FreeBSD.org>
Subject: Re: svn commit: r252032 - head/sys/amd64/include
References: <201306201430.r5KEU4G5049115@svn.freebsd.org>
In-Reply-To: <201306201430.r5KEU4G5049115@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
 autolearn=unavailable version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2013 02:15:28 -0000

Hi Kostik,

On 06/21/13 00:30, Konstantin Belousov wrote:
> Author: kib
> Date: Thu Jun 20 14:30:04 2013
> New Revision: 252032
> URL: http://svnweb.freebsd.org/changeset/base/252032
> 
> Log:
>   Allow immediate operand.
>   
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/sys/amd64/include/counter.h
> 
> Modified: head/sys/amd64/include/counter.h
> ==============================================================================
> --- head/sys/amd64/include/counter.h	Thu Jun 20 14:20:03 2013	(r252031)
> +++ head/sys/amd64/include/counter.h	Thu Jun 20 14:30:04 2013	(r252032)
> @@ -44,7 +44,7 @@ counter_u64_add(counter_u64_t c, int64_t
>  
>  	__asm __volatile("addq\t%1,%%gs:(%0)"
>  	    :
> -	    : "r" ((char *)c - (char *)&__pcpu[0]), "r" (inc)
> +	    : "r" ((char *)c - (char *)&__pcpu[0]), "ri" (inc)
>  	    : "memory", "cc");
>  }

For mere mortals like myself, a verbose explanation of what this does,
why it's necessary and what problem(s) it solves (if any) would be most
helpful :)

Cheers,
Lawrence