Date: Mon, 30 Jan 2023 09:58:55 -0700 From: Warner Losh <imp@bsdimp.com> To: Dmitry Salychev <dsl@mcusim.org> Cc: Kurt Jaeger <pi@freebsd.org>, Stephane Rochoy <stephane.rochoy@stormshield.eu>, freebsd-current@freebsd.org Subject: Re: Tooling Integration and Developer Experience Message-ID: <CANCZdfrpx9MW0wE0oWnkk5LmqbMVVaC_2z5fzaidK4QnRG2eTg@mail.gmail.com> In-Reply-To: <86zga0nf1q.fsf@peasant.tower.home> References: <202301300254.30U2sm0k061914@dell.no.berklix.net> <97020cad-f913-2985-2093-e4c23bf671e3@antonovs.family> <86357sxsly.fsf@cthulhu.stephaner.labo.int> <Y9eepV%2B%2Bch6qMBta@home.opsec.eu> <86edrcp13z.fsf@peasant.tower.home> <CANCZdfp7RpYyGH1-yx-ddaibwM3=sfYOYw8m7mKjJ4gfWjUW6Q@mail.gmail.com> <86zga0nf1q.fsf@peasant.tower.home>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] I think just "sys/dev/dpaa2" is all you need when adding the Herald rule. :) More generally, no, there's no way that I've found to only match files that match certain regexp. Warner On Mon, Jan 30, 2023 at 9:49 AM Dmitry Salychev <dsl@mcusim.org> wrote: > > Warner Losh <imp@bsdimp.com> writes: > > > On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev <dsl@mcusim.org> wrote: > > > > Hi, > > > > Kurt Jaeger <pi@freebsd.org> writes: > > > > > Hi, > > > > > >> > On 1/30/23 02:54, Julian H. Stacey wrote: > > >> > The main idea: to prevent information fragmentation and > improve > > >> > discoverability, cross-referencing abilities, search, etc. > > >> > > >> With regards to improving discoverability, Phabricator's Owner > > >> tool could be a good tactical move: it allow to bind code area to > > >> peoples in order to automatically add them to reviews. > > > > > > If you know phabricator in more detail, is there any kind of tool > > > to understand the activity going on ? > > > > > > In bugs.freebsd.org, there is the dashboard: > > > > > > https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html > > > > > > I think we might need something similar to help us understand > > > the current state of the phabricator instance and the work > > > being done. > > > > > > Phab allows Dashboards, but no-one had the time to configure some > > > queries to provide relevant stats. > > > > I'd prefer to have an automatic note via email from Phabricator if any > > file with my copyright was modified/patched/improved in a newly opened > > review. > > > > I don't think that people tend to ignore changes to those parts of code > > they've written (or touched at least). > > > > You can easily create a herald rule to do this. I have one for all of > src, but others have subsets > > like the boot loader. And anybody with an account can do that. > > > > Warner > > Looks really useful, thanks for a hint. Is there any way to test regexp > matching for files content? Btw, there could be a carefully selected set > of pre-defined Herald rules added to any new committer's account. > > -- > Dmitry Salychev > [-- Attachment #2 --] <div dir="ltr">I think just "sys/dev/dpaa2" is all you need when adding the Herald rule. :)<div><br></div><div>More generally, no, there's no way that I've found to only match files that match certain regexp.</div><div><br></div><div>Warner</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 30, 2023 at 9:49 AM Dmitry Salychev <<a href="mailto:dsl@mcusim.org">dsl@mcusim.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank">imp@bsdimp.com</a>> writes:<br> <br> > On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev <<a href="mailto:dsl@mcusim.org" target="_blank">dsl@mcusim.org</a>> wrote:<br> ><br> > Hi,<br> ><br> > Kurt Jaeger <<a href="mailto:pi@freebsd.org" target="_blank">pi@freebsd.org</a>> writes:<br> ><br> > > Hi,<br> > ><br> > >> > On 1/30/23 02:54, Julian H. Stacey wrote:<br> > >> > The main idea: to prevent information fragmentation and improve<br> > >> > discoverability, cross-referencing abilities, search, etc.<br> > >> <br> > >> With regards to improving discoverability, Phabricator's Owner<br> > >> tool could be a good tactical move: it allow to bind code area to<br> > >> peoples in order to automatically add them to reviews.<br> > ><br> > > If you know phabricator in more detail, is there any kind of tool<br> > > to understand the activity going on ?<br> > ><br> > > In <a href="http://bugs.freebsd.org" rel="noreferrer" target="_blank">bugs.freebsd.org</a>, there is the dashboard:<br> > ><br> > > <a href="https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html</a><br>; > ><br> > > I think we might need something similar to help us understand<br> > > the current state of the phabricator instance and the work<br> > > being done.<br> > ><br> > > Phab allows Dashboards, but no-one had the time to configure some<br> > > queries to provide relevant stats.<br> ><br> > I'd prefer to have an automatic note via email from Phabricator if any<br> > file with my copyright was modified/patched/improved in a newly opened<br> > review.<br> ><br> > I don't think that people tend to ignore changes to those parts of code<br> > they've written (or touched at least).<br> ><br> > You can easily create a herald rule to do this. I have one for all of src, but others have subsets<br> > like the boot loader. And anybody with an account can do that.<br> ><br> > Warner<br> <br> Looks really useful, thanks for a hint. Is there any way to test regexp<br> matching for files content? Btw, there could be a carefully selected set<br> of pre-defined Herald rules added to any new committer's account.<br> <br> -- <br> Dmitry Salychev<br> </blockquote></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrpx9MW0wE0oWnkk5LmqbMVVaC_2z5fzaidK4QnRG2eTg>