From nobody Mon Feb 28 17:50:38 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 71D5319EFD51; Mon, 28 Feb 2022 17:50:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6nwZ26cpz3mrP; Mon, 28 Feb 2022 17:50:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646070638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gd30vO5Dl8zMNPJ0N+i5n0RRlAzfaqg+aR2NT0faFbA=; b=mS/7Iax/hD9ftxz7SkhLrtXs9B6QjlEA9jNMSs6TfiH8P9U74CUcDV/60671ffJ60+EKwn TxdEn7dybREDs/I6f5O1LU6sWZtbB4wVchZin5ghrBzARfrnIYsChp4GAnI/JgbRKQJpxn tF7ux4vTG/o/yzB6fyrkQFPuW0nfMvkIGGmG20QTFuvnFD4hk0KOV6eqohuFgj6bwvYwHK rKvTMMs6Bq7MR1U2GtsKl4/dfqVS/LNKxqC2MFML9qNVUv5dEifCCIK8r2VyCFyoYiXE40 bwTr/0e9S/B3X0rPlbAXOGwOSmngeAAcKYR92ZaigyF6wwlfYIr2wAdI+7jLFg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 26A001FADA; Mon, 28 Feb 2022 17:50:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21SHocs8068408; Mon, 28 Feb 2022 17:50:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21SHocVJ068406; Mon, 28 Feb 2022 17:50:38 GMT (envelope-from git) Date: Mon, 28 Feb 2022 17:50:38 GMT Message-Id: <202202281750.21SHocVJ068406@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 44b4f0370fe9 - main - bnxt: Remove dead write to cp_ring_id List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 44b4f0370fe90d11306e9d3fdcacdc5b4ccc946e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646070638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gd30vO5Dl8zMNPJ0N+i5n0RRlAzfaqg+aR2NT0faFbA=; b=we0qiKqSOX+nhI919gD1EZ+PUSJGxhpwzp1eIpUEKiBPMUbv92rajbSinD97ge2d3xN9lb YI8hdX58pQzDN3LsuscIh4n3oTzx2mYosHFEGz0Yv9xo/VbZc7+6AvDoDdKN3v5BnW+2zh JPUYNiyY0h9lVIX/gQiLSsjsRm6yRQZt6d8R8OpOJQr6Rk12fjkTrtbPO41XcmHGdWPoWa sOPLlnaUB9HlORGZ0rB72iah8lNF0tJsp2BMphSMoflDvZ9WPa48GeHh5DuuQfw/VD4Wm9 YqhZtMFvifIgaOZW5H0T7iMDOIA0GTqwikXT4XNIX9PAKMsqPRU9JEB4VjwSRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646070638; a=rsa-sha256; cv=none; b=WWpZQ0TbizpfTkDMzbGBXUjA4GarOYhB6/ZNZZatvryPc8aUlS/4fICUcLqtAnsSqksQwd PCYV68F/V5vMrZ/TZNz0HM9tQFVx/sBYdl9CHi/5UK7Qh5Z7ZURQ3vmIfL91OOzBqXiPeE sz2ylhVvrNNJWssTSHgtp0jSXWPY7Y2fwbd+OA1EZwmqT30m1DEsjP0l/L9guBlPS5yFz9 0NLx0yw/CK2u64Xf6t5keL+RMHtIhwGy7mL6fegWf21Bhr25QK/Id9Zm1e0DWNtaibXP9z vjQDNvbZGDKCEeKIezFnaXiEmx8RUpkFotDQEPgQ3RXFLmEbTzkoPejues8Deg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=44b4f0370fe90d11306e9d3fdcacdc5b4ccc946e commit 44b4f0370fe90d11306e9d3fdcacdc5b4ccc946e Author: Warner Losh AuthorDate: 2022-02-28 17:13:27 +0000 Commit: Warner Losh CommitDate: 2022-02-28 17:14:34 +0000 bnxt: Remove dead write to cp_ring_id Since this is read from memory, reading it and then ignoring it is dead code... Sponsored by: Netflix --- sys/dev/bnxt/bnxt_hwrm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_hwrm.c b/sys/dev/bnxt/bnxt_hwrm.c index 60485cd06799..0009ffa25053 100644 --- a/sys/dev/bnxt/bnxt_hwrm.c +++ b/sys/dev/bnxt/bnxt_hwrm.c @@ -119,7 +119,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) struct hwrm_err_output *resp = (void *)softc->hwrm_cmd_resp.idi_vaddr; uint32_t *data = msg; int i; - uint16_t cp_ring_id; uint8_t *valid; uint16_t err; uint16_t max_req_len = HWRM_MAX_REQ_LEN; @@ -128,7 +127,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) /* TODO: DMASYNC in here. */ req->seq_id = htole16(softc->hwrm_cmd_seq++); memset(resp, 0, PAGE_SIZE); - cp_ring_id = le16toh(req->cmpl_ring); if (softc->flags & BNXT_FLAG_SHORT_CMD) { void *short_cmd_req = softc->hwrm_short_cmd_req_addr.idi_vaddr;