From owner-freebsd-perl@FreeBSD.ORG Sat Oct 18 15:44:07 2008 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B76461065699 for ; Sat, 18 Oct 2008 15:44:07 +0000 (UTC) (envelope-from leeym@leeym.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30]) by mx1.freebsd.org (Postfix) with ESMTP id 7ECED8FC15 for ; Sat, 18 Oct 2008 15:44:07 +0000 (UTC) (envelope-from leeym@leeym.com) Received: by yx-out-2324.google.com with SMTP id 8so203574yxb.13 for ; Sat, 18 Oct 2008 08:44:06 -0700 (PDT) Received: by 10.100.105.15 with SMTP id d15mr6699078anc.69.1224342814497; Sat, 18 Oct 2008 08:13:34 -0700 (PDT) Received: by 10.100.127.9 with HTTP; Sat, 18 Oct 2008 08:13:34 -0700 (PDT) Message-ID: <759236930810180813r415eaae2of299ebed951632a8@mail.gmail.com> Date: Sat, 18 Oct 2008 08:13:34 -0700 From: "Yen-Ming Lee" To: tobez@freebsd.org In-Reply-To: <200810181406.m9IE6jW8067588@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200810181406.m9IE6jW8067588@freefall.freebsd.org> Cc: perl@freebsd.org Subject: Re: ports/128187: [PATCH] devel/p5-Parse-RecDescent: simplfy dependency X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Oct 2008 15:44:07 -0000 2008/10/18 : > Synopsis: [PATCH] devel/p5-Parse-RecDescent: simplfy dependency > > State-Changed-From-To: open->feedback > State-Changed-By: tobez > State-Changed-When: Sat Oct 18 16:02:19 CEST 2008 > State-Changed-Why: > With regard making the dependency conditional on the perl version, > I actually think that the better way to do it is to add modifications > to bsd.perl.mk that we developed together with lth. But I do not have a > principal objection to this. > > With regard to getting rid of BUILD_DEPENDS altogether, could > you explain your reasoning behind it? In my view, by not > doing the BUILD_DEPENDS bit, we a) introduce a spurious warning > into the configure stage in at least some cases, and b) make it more > difficult than necessary to do the testing without installing the > modules. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=128187 > Hi, The main reason is to keep minimal dependencies. I explained once in another PR, and asked for feedbacks. However, nobody replied, so I just assume that everyone agreed. (see solution 2) About the dependencies, we have the following solutions: 1. (I did so before) put 'requires' in BUILD_DEPENDS and RUN_DEPENDS, and then append 'build_requires' to BUILD_DEPENDS. The trade-off is that we will bring a lot of unnecessary dependencies, like some dual-life modules or some p5-Test-* that only needed for tests, and des@ doesn't like that. http://lists.freebsd.org/pipermail/freebsd-perl/2008-February/001745.html http://lists.freebsd.org/pipermail/freebsd-perl/2008-February/001748.html 2. (I'm doing so now) put 'requires' in RUN_DEPENDS, and put something in BUILD_DEPENDS if really needed. Also use conditional dependencies to avoid dual-life modules. It complains during the configure stage, but it works well. http://lists.freebsd.org/pipermail/freebsd-perl/2008-July/001900.html 3. use PERL_DEPENDS, but we still need to find out the relationship between the minimum version of the required module and the package version fulfill that minimum version of the module. In fact I encounter this problem again recently: Net::Amazon::S3-0.45 requires IO::File-0.14, which is from IO, but obviously not IO-0.14 http://lists.freebsd.org/pipermail/freebsd-perl/2008-April/001834.html We discussed about it several times, please make a decision this time and put it somewhere in the porters handbook. Regards, -- Yen-Ming Lee