From owner-freebsd-net@FreeBSD.ORG  Thu Jun  9 09:48:35 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3B8B816A41C
	for <freebsd-net@freebsd.org>; Thu,  9 Jun 2005 09:48:35 +0000 (GMT)
	(envelope-from mjl@luckie.org.nz)
Received: from grunt9.ihug.co.nz (grunt9.ihug.co.nz [203.109.254.51])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C2F4A43D1D
	for <freebsd-net@freebsd.org>; Thu,  9 Jun 2005 09:48:33 +0000 (GMT)
	(envelope-from mjl@luckie.org.nz)
Received: from 203-173-150-184.bliink.ihug.co.nz (lycra.luckie.org.nz)
	[203.173.150.184] 
	by grunt9.ihug.co.nz with esmtp (Exim 3.35 #1 (Debian))
	id 1DgJeF-0000cK-00; Thu, 09 Jun 2005 21:48:27 +1200
Received: from 203-173-146-91.bliink.ihug.co.nz ([203.173.146.91]
	helo=[192.168.1.6])
	by lycra.luckie.org.nz with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.51 (FreeBSD))
	id 1DgJeE-0004sw-6s; Thu, 09 Jun 2005 21:48:26 +1200
Message-ID: <42A81065.8010603@luckie.org.nz>
Date: Thu, 09 Jun 2005 21:48:21 +1200
From: Matthew Luckie <mjl@luckie.org.nz>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050530
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Bruce M Simpson <bms@spc.org>
References: <4295A6CA.8080409@luckie.org.nz>
	<20050606081637.GA73886@lycra.luckie.org.nz>
	<20050606120851.GD734@empiric.icir.org>
	<20050606204008.GA91353@lycra.luckie.org.nz>
	<20050607101927.GA99034@lycra.luckie.org.nz>
	<20050607112340.GC812@empiric.icir.org>
In-Reply-To: <20050607112340.GC812@empiric.icir.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: bpf writes on tun device
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2005 09:48:35 -0000

> I'd suggest a name like DLT_PSEUDO might be better -- it may be helpful to
> get review for the change from the NetBSD and OpenBSD guys too, as well as
> the tcpdump.org guys.

I posted a patch to netbsd tech-kern and have had positive feedback:

http://mail-index.netbsd.org/tech-net/2005/06/09/0003.html

I posted to tcpdump-workers and have had no response at this time:

http://marc.theaimsgroup.com/?l=tcpdump-workers&m=111818619022560&w=2

I do, however, feel that this is a safe patch to apply, and one that I'd 
really like to see make it to 6.0.

> Looking at style, it might be better if the driver(s) were changed to
> explicitly use a 32-bit wide int type such as u_int32_t for the address
> family header field in their bpfattach() calls. ICHDRLEN is odd man out,
> but it is #define'd to be the same thing; I would update it there also.

I'll do some house keeping on the patch and then re-send it.  I take it 
a PR is the right place to send the patch?

> A white space pass should probably also be done last thing to be sure.
> I have no idea about ng_sppp.c I'm afraid.

I'll make a note in the PR about ng_sppp.c; but there does not appear to 
be any output function specific to ng_sppp so I think it is safe to 
leave alone.

Thanks

Matthew