From owner-p4-projects@FreeBSD.ORG  Mon Oct  1 17:17:09 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DB4D916A4FF; Mon,  1 Oct 2007 17:17:08 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B4AC16A417
	for <perforce@FreeBSD.org>; Mon,  1 Oct 2007 17:17:08 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 8795713C457
	for <perforce@FreeBSD.org>; Mon,  1 Oct 2007 17:17:08 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91HH8HI011810
	for <perforce@FreeBSD.org>; Mon, 1 Oct 2007 17:17:08 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91HH8Bs011807
	for perforce@freebsd.org; Mon, 1 Oct 2007 17:17:08 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Mon, 1 Oct 2007 17:17:08 GMT
Message-Id: <200710011717.l91HH8Bs011807@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 127066 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2007 17:17:09 -0000

http://perforce.freebsd.org/chv.cgi?CH=127066

Change 127066 by hselasky@hselasky_laptop001 on 2007/10/01 17:16:23

	
	Optimise;
	 1) No need to preset the "status" variable.
	 2) No need to compute last data toggle at every iteration.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/ehci.c#41 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/ehci.c#41 (text+ko) ====

@@ -1076,12 +1076,9 @@
 	ehci_qtd_t *td_alt_next;
 	uint32_t status;
 	uint16_t len;
-	uint8_t last_toggle;
 
 	td = xfer->td_transfer_cache;
 	td_alt_next = td->alt_next;
-	status = EHCI_QTD_HALTED;
-	last_toggle = 0;
 
 	while (1) {
 
@@ -1104,9 +1101,6 @@
 	        xfer->frlengths[xfer->aframes] -= len;
 	    }
 
-	    /* Make a copy of the data toggle */
-	    last_toggle = (status & EHCI_QTD_TOGGLE_MASK) ? 1 : 0;
-
 	    /* Check for last transfer */
 	    if (((void *)td) == xfer->td_transfer_last) {
 	        if (len == 0) {
@@ -1153,7 +1147,8 @@
 
 	/* update data toggle */
 
-	xfer->pipe->toggle_next = last_toggle;
+	xfer->pipe->toggle_next =
+	  (status & EHCI_QTD_TOGGLE_MASK) ? 1 : 0;
 
 #ifdef USB_DEBUG
 	if (status & EHCI_QTD_STATERRS) {