From owner-p4-projects@FreeBSD.ORG  Fri Jan  2 15:09:50 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DD0DB16A4D0; Fri,  2 Jan 2004 15:09:49 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B63F016A4CE; Fri,  2 Jan 2004 15:09:49 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 563B543D5E; Fri,  2 Jan 2004 15:09:48 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from 66.127.85.91 ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id i02N9lHQ067949
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Fri, 2 Jan 2004 15:09:48 -0800 (PST)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: John Baldwin <jhb@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Date: Fri, 2 Jan 2004 15:13:38 -0800
User-Agent: KMail/1.5.3
References: <200401022204.i02M4ob5010556@repoman.freebsd.org>
In-Reply-To: <200401022204.i02M4ob5010556@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200401021513.38759.sam@errno.com>
Subject: Re: PERFORCE change 44709 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jan 2004 23:09:50 -0000

On Friday 02 January 2004 02:04 pm, John Baldwin wrote:
> http://perforce.freebsd.org/chv.cgi?CH=44709
>
> Change 44709 by jhb@jhb_blue on 2004/01/02 14:04:27
>
> 	Bah, stupid bug.
>
> Affected files ...
>
> .. //depot/projects/smpng/sys/modules/crash/crash.c#8 edit
>
> Differences ...
>
> ==== //depot/projects/smpng/sys/modules/crash/crash.c#8 (text+ko) ====
>
> @@ -234,9 +234,9 @@
>  			break;
>  		case 18:
>  			bzero(&test1_mtx, sizeof(test1_mtx));
> -			bzero(&test1_mtx, sizeof(test2_mtx));
> +			bzero(&test2_mtx, sizeof(test2_mtx));
>  			mtx_init(&test1_mtx, "test1", NULL, MTX_DEF);
> -			mtx_init(&test1_mtx, "test2", NULL, MTX_DEF |
> +			mtx_init(&test2_mtx, "test2", NULL, MTX_DEF |
>  			    MTX_RECURSE);
>  #define TRYLOCK_TEST(lock, descr) do {					\
>  	status = mtx_trylock((lock));					\

Bah bah, bogus assertions.

	Sam