From owner-cvs-all@FreeBSD.ORG Sat Dec 24 21:19:57 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C932516A41F; Sat, 24 Dec 2005 21:19:57 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9924B43D55; Sat, 24 Dec 2005 21:19:49 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: by toxic.magnesium.net (Postfix, from userid 1252) id 480F1DA8A0; Sat, 24 Dec 2005 13:19:48 -0800 (PST) Date: Sat, 24 Dec 2005 16:19:48 -0500 From: Adam Weinberger To: Joe Marcus Clarke Message-ID: <20051224211948.GA63136@toxic.magnesium.net> Mail-Followup-To: Adam Weinberger , Joe Marcus Clarke , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org References: <200512241655.jBOGtVme037133@repoman.freebsd.org> <1135443852.77025.14.camel@shumai.marcuscom.com> <20051224210134.GB58667@toxic.magnesium.net> <1135458317.64667.0.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1135458317.64667.0.camel@shumai.marcuscom.com> X-Editor: Vim 6.3 http://www.vim.org X-Mailer: Mutt 1.5 http://www.mutt.org X-PGP-Key: http://www.vectors.cx/pgp.key.txt X-URL: http://www.vectors.cx X-ASL: 6/m/behind you User-Agent: Mutt/1.5.4i Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/libsoup Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2005 21:19:57 -0000 >> (12.24.2005 @ 1605 PST): Joe Marcus Clarke said, in 1.5K: << > On Sat, 2005-12-24 at 16:01 -0500, Adam Weinberger wrote: > > >> (12.24.2005 @ 1204 PST): Joe Marcus Clarke said, in 1.0K: << > > > On Sat, 2005-12-24 at 16:55 +0000, Adam Weinberger wrote: > > > > adamw 2005-12-24 16:55:31 UTC > > > > > > > > FreeBSD ports repository > > > > > > > > Modified files: > > > > devel/libsoup Makefile > > > > Log: > > > > Add PTHREAD_CFLAGS/LIBS to CONFIGURE_ENV, and make LDFLAGS actually > > > > be a part of CONFIGURE_ENV. > > > > > > You have to treat LDFLAGS specially because of OpenSSL. Also, we really > > > need Ade to look into this libtool problem. We shouldn't have to hack > > > all of these ports when it seems pretty clear the new libtool is at > > > fault here. > > >> end of "Re: cvs commit: ports/devel/libsoup Makefile" from Joe Marcus Clarke << > > > > w0rd. I've backed it out and put LDFLAGS back where it belongs. Should > > it be passed to CONFIGURE_ENV though? > > No. bsd.openssl.mk takes care of that for us. > > Joe >> end of "Re: cvs commit: ports/devel/libsoup Makefile" from Joe Marcus Clarke << Hrmmn. I'm pretty sure that when I added ${PTHREAD_LIBS} to that LDFLAGS line, it didn't get passed to configure. At least, the build still failed anyway. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx It's not stupid. It's "advanced." -- Almighty Tallest