From owner-freebsd-hackers@FreeBSD.ORG  Wed Dec 10 16:21:24 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 372701065672;
	Wed, 10 Dec 2008 16:21:24 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id E81778FC08;
	Wed, 10 Dec 2008 16:21:23 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id F18FE6D44C;
	Wed, 10 Dec 2008 16:21:22 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id D7853844DD; Wed, 10 Dec 2008 17:21:22 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: "Ivan Voras" <ivoras@freebsd.org>
References: <ghjt9l$hg3$1@ger.gmane.org> <863agws2bv.fsf@ds4.des.no>
	<ghog9e$r4e$1@ger.gmane.org> <87bpvkdqex.fsf@kobe.laptop>
	<9bbcef730812100720h5b3aab6ek46c4f36c67a37d58@mail.gmail.com>
Date: Wed, 10 Dec 2008 17:21:22 +0100
In-Reply-To: <9bbcef730812100720h5b3aab6ek46c4f36c67a37d58@mail.gmail.com>
	(Ivan Voras's message of "Wed, 10 Dec 2008 16:20:41 +0100")
Message-ID: <86iqpsknlp.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Giorgos Keramidas <keramida@ceid.upatras.gr>, freebsd-hackers@freebsd.org
Subject: Re: MAXFILES in subr_param.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2008 16:21:24 -0000

"Ivan Voras" <ivoras@freebsd.org> writes:
> The macro is defined and used exactly once, in this file. Other files
> probably use maxfiles.

maxfiles is the real value; it's a loader tunable, and more importantly,
it can be modified at run time through the kern.maxfiles sysctl
variable.  MAXFILES is simply the default value to which maxfiles is
initialized.

> The problem is - since it's in an #ifdef block
> - is it defined anywhere else? A quick grep yields only this:
>
> conf/NOTES:options 	MAXFILES=3D999
> conf/options:MAXFILES	opt_param.h
>
> I don't know how config interacts with the source - does it shadow the
> subr_param.c value?

Yes.  If you use the MAXFILES option in your kernel config, config(8)
will add a corresponding #define MAXFILES to opt_param.h.

I doubt anyone would complain (or even notice) if you removed it
entirely.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no