From owner-freebsd-net@FreeBSD.ORG Wed Feb 10 17:08:35 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FB661065693; Wed, 10 Feb 2010 17:08:35 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-gx0-f218.google.com (mail-gx0-f218.google.com [209.85.217.218]) by mx1.freebsd.org (Postfix) with ESMTP id 7D8108FC13; Wed, 10 Feb 2010 17:08:34 +0000 (UTC) Received: by gxk10 with SMTP id 10so241007gxk.3 for ; Wed, 10 Feb 2010 09:08:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:in-reply-to:message-id:references:user-agent :x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; bh=vf8tEWLyxYtXDUI8ow/8xP2wgu3zq49+MbKpFCrqcgs=; b=hYS0i4z1DJ2CGdm0zxD/AAwMHQAgVCjvJbjVgW9/EI0LdTszdhnQOrhFTjn+j8fP+A yzfZGH4Q/IiM0NQDVKZnfEDgqzVnAU/D5z//ULjXWO1hUj+ZFPuUmvEqEDbbDCxuR0/h 3JSi0v1TIEF2NhYZXWDZ5tc/b6wlGO4FQoJi0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=pFBzowke7ASbh1VJtXnj1EHpWGEWbeEwzGS3FaGx9+jaoH/PfXN2Q0uVJZzwbWvkEw aBYGNPKtG1yN1sV47CyuFqPKrsjlMZ50pwX0rMKHdjjERk08JLkQRmsCoOnMgicdCMs4 JXgJRUrf12FaOYP8xEnkwbJMkAan/+5FTZstY= Received: by 10.150.252.14 with SMTP id z14mr2829990ybh.72.1265821713579; Wed, 10 Feb 2010 09:08:33 -0800 (PST) Received: from centel.dataix.local (ppp-21.19.dialinfree.com [209.172.21.19]) by mx.google.com with ESMTPS id 6sm522328ywc.8.2010.02.10.09.08.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Feb 2010 09:08:31 -0800 (PST) Sender: "J. Hellenthal" Date: Wed, 10 Feb 2010 12:08:32 -0500 From: jhell To: Balaji G In-Reply-To: <6dd1343e1002092253j5b111d42m7c354ca372241dde@mail.gmail.com> Message-ID: References: <6dd1343e1002080739m38f4deffr604c71e5036389a4@mail.gmail.com> <6dd1343e1002092253j5b111d42m7c354ca372241dde@mail.gmail.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org, "Li, Qing" , Qing Li Subject: Re: [PATCH] net:: ECMP Phase 1 Fixes for FreeBSD 7.2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2010 17:08:35 -0000 On Wed, 10 Feb 2010 01:53, balajig81@ wrote: > Hi Jhell > >> Delete keys get in the way some times ;) > > I am sorry i didn't understand your comment. Is it wrong or should i change > something, please let me know so that i could create an other patch . > Please see below. > PS: I had also sent an email to the list to take up some items mentioned in > the Wiki Page under the networking section. It would be nice if by any > chance you know who's the contact person :). for those activities. > I do not remember who the contact person is at the moment but it would be safe to say he/she is probably watching mailing list. > Thanks for your feedback and time :) > > Thanks, > Cheers, > - Balaji > > > On Wed, Feb 10, 2010 at 12:11 PM, jhell wrote: > >> >> On Mon, 8 Feb 2010 10:39, balajig81@ wrote: >> >>> Hi Everybody >>> >>> Please find attached the patch files which contains the backported code >>> for >>> ECMP for FreeBSD 7.2. I have back ported the code from 8.0. I have done >>> some >>> basic testing with these patches rolled in. These are the phase 1 fixes >>> and >>> i would continue to work on this and back port few other stuff too. It >>> would >>> be great if someone could roll in this to 7.2, test it and give me their >>> valuable feedback. >>> >>> This is my first Patch for FreeBSD community and i am really excited about >>> this and look forward to it. >>> >>> Thanks for your time. >>> >>> Cheers, >>> - Balaji >>> >>> >> In ecmp_patch1 you have, >> >> @@ -320,8 +320,9 @@ >> #endif >> >> extern int in6_inithead(void **head, int off); >> -extern int in_inithead(void **head, int off); >> +extern int in_inthead(void **head, int off); >> Problem is with the above two lines explicitly "in_inthead" should be "in_inithead" but it looked to me like it was a mistake and that you did not mean to delete the "i" which is why I said the following. >> ?? >> >> Delete keys get in the way some times ;) >> >> -- >> >> jhell >> >> > Best regards. -- jhell