From owner-svn-src-all@freebsd.org Thu Nov 21 16:32:57 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9607C1C45A4; Thu, 21 Nov 2019 16:32:57 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JlV13NQPz4d4N; Thu, 21 Nov 2019 16:32:57 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id B8F7412880; Thu, 21 Nov 2019 16:32:56 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Thu, 21 Nov 2019 16:32:54 +0000 From: Glen Barber To: Ian Lepore Cc: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team , Colin Percival Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191121163254.GO5599@FreeBSD.org> References: <201911201836.xAKIawWt053874@repo.freebsd.org> <20191121161337.GA92849@FreeBSD.org> <20191121162311.GN5599@FreeBSD.org> <3ed399dae42291005a5b88e426018697b47d8419.camel@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zpx5Rz5PkYgiNBE6" Content-Disposition: inline In-Reply-To: <3ed399dae42291005a5b88e426018697b47d8419.camel@freebsd.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 16:32:57 -0000 --Zpx5Rz5PkYgiNBE6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 09:28:50AM -0700, Ian Lepore wrote: > On Thu, 2019-11-21 at 16:23 +0000, Glen Barber wrote: > > On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote: > > > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > > > > Author: brooks > > > > Date: Wed Nov 20 18:36:58 2019 > > > > New Revision: 354909 > > > > URL: https://svnweb.freebsd.org/changeset/base/354909 > > > >=20 > > > > Log: > > > > Make the warning for deprecated NO_ variables an error. > > > > =20 > > > > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, > > > > NO_PROFILE, > > > > and NO_WARNS as deprecated in 2014 with a warning added for > > > > each one > > > > found. Turn these into error in preperation for removal of > > > > compatability > > > > support before FreeBSD 13. > > > > =20 > > > > Reviewed by: imp > > > > Relnotes: yes > > > > Sponsored by: DARPA, AFRL > > > > Differential Revision: https://reviews.freebsd.org/D22448 > > > >=20 > > > > Modified: head/share/mk/bsd.opts.mk > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 ( > > > > r354908) > > > > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 ( > > > > r354909) > > > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > > > PROFILE \ > > > > WARNS > > > > .if defined(NO_${var}) > > > > -.warning "NO_${var} is defined, but deprecated. Please use > > > > MK_${var}=3Dno instead." > > > > +.error "NO_${var} is defined, but deprecated. Please use > > > > MK_${var}=3Dno instead." > > > > MK_${var}:=3Dno > > > > .endif > > > > .endfor > > > >=20 > > >=20 > > > Had this been exp-run tested? This breaks at least the > > > net/bsdec2-image-upload port, which does *not* set NO_MAN > > > explicitly in > > > its Makefile. I suspect at least several other ports are now > > > implicitly > > > broken as result of this change. > > >=20 > >=20 > > In fact, on a quick search through ports/*/*/Makefile, I do not see > > NO_MAN defined *anywhere*. So, this is pulled in from somewhere > > else, > > which now I have a feeling more ports than I initially thought are > > now > > broken. > >=20 >=20 > Your search was too narrow. Re-do it as "grep -Rw NO_MAN *" from > /usr/ports and you'll get a lot of hits from within files/ dirs. >=20 Thank you for that; I forgot about the files/ directories. Nonetheless, net/bsdec2-image-upload still does not explicitly set this knob. Glen --Zpx5Rz5PkYgiNBE6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl3WvDYACgkQAxRYpUeP 4pM33w/9HDQsEin+9IiRyDWUt2QZa9xjg7dqKVEvx1M2uSYRlHb9CTApj3yRJiIO yunN+O9zXoJxulYotUsueXBT5kkMSTmj3Z1eAReuL1ykEiu7bqjVpj3WlZHnq//p 410/f7+V4Vx2IDKaoJZR8ZaK8ZorjU6ncXJ53nRguG6gTL0n6fv1CxnG04h3zo+l 7evwL4lgYJZYjRIjsP/jc4EMUbuoCY5C9/sDlt4D0qEEv93Qbx9L9YLAlD1pUiLu kYw+5+O7owSZpv9lZnxK0ObcUHo0gWI0hZ5DH3oCMinIxT8SuDDwdnFFFpdstn9g ury/IMypElzBWHC0CHJi4VcjC0XQG0i/fxlM8m8KrwIr++WDLbZeLVjCxqHE6EKK Vury7KEcaitrbf1/ZkoB/eRvDBvquaa/u0GkxwHMdEIRqvdljZy1o0OGpL6mX3Oj 33X2zf8Hg2zfRhNy6aZoP9tiue+uyUI3BIGIJGPyuv9V6LAqsDiW6JAAAwLZBWeI jDvwGVzHs79qgz3r7ANXGuJY0XvIBlPYebBwlNGlkqoPacXRz44g4RgOj1agsDyV +UWT6ENFqXNjzTrs7JUKDUV3gIaTNOftvpgamdos9lm+eTLWdOGRg5JVz8phUKzW Ci2/qPcZ8Q8bbIkRC6+UTYz41eSHFdEIqS839WBQgtv425maXTI= =eyXc -----END PGP SIGNATURE----- --Zpx5Rz5PkYgiNBE6--