From nobody Mon Jun 2 23:33:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bB9BQ1sgDz5xZ0s; Mon, 02 Jun 2025 23:33:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bB9BQ18hnz3tRD; Mon, 02 Jun 2025 23:33:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748907182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ghH6ofmbMXxzeqZH3LOtVl6tazuFMTjPBbzuW5B0UrE=; b=EqJYIqtT5po+URcWlV6XDucMGjzlZ3Sq1tm3cW+hAsfK55OUW36OQcvHJqkKM9wHCWfFb/ TXzFZKySZvedX5xQGMHNgOstdNqoyTCkhLq4Z5qDZclP6BglvC/8nwud+87pwac5Ahms9/ mYc3CISYdtg9dtMgegM1S//ckIvQJIpR4gWcg0uFpawsGO9LsZCc1C+3hwM2rI6Dct+xTx 2LmjRQWors7ou7j1X4xRX4ySHRLlkO0zmEVi5eG2vqUzQl1+YzAPYZeOx4XPza7ernYEFB 1WjYsi5BEI+WRCmwmY/GtaEyt8pNd2rJAAj+UsC8yoxWs+ZE3YLr4CQaJCLC0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748907182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ghH6ofmbMXxzeqZH3LOtVl6tazuFMTjPBbzuW5B0UrE=; b=PJkTyQbOzVJDiUKqc5zXKKTxwprA0u+3E3G8K2++oZm8drF2Z2Pc7jUd/YYyRKkEE0hPFH 9DDGbvFf3oWiwhFsqzROHrzP1uv7rSPfjxZoZpXEHi1H4AO5qwwkqx9Cyzc8cCMIXDm842 bXB9CjCNNXcpPyzwVT+25YQj5dyqUCsbfXcj9Ll1R0iyF097HiM/lkSKWWfvb9tvTGpMH2 YL13J3TWPu6Uy6MEQF3nQCRqK3VNeuuDhtvYDIHnxWELaMIGfYriu02gDqH2UvFzXWvV/D vN1uq3gobHoVIRaQ2xfO7nfI+lkYFZSaVwAvdp5hbfEt3dsHnPTs6CCsHCQLYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748907182; a=rsa-sha256; cv=none; b=cYViUSv7aLUqS8H8u3CEHemlFgZ5RW/rOewEYH/xaOoqinypeAcAjd9G0Y77GnlibQnfma 79GHMRSSKtj0Totow25pJxv/f5Z8DrMP1v5WUvn94//gs9T8/hcod3HN9vM4XyeGE+DOFK uYvc/c89zwuH7YUqo7tyZQEsZeBZRtbKBEEMuVjbpGzoMLVZNMprEg24Os+hIDFirUSVb7 vkJAkjEvNBNVIflvCMmaAUcrHQub3TSegJDlJd11/R++NYBbkqVB/geXKiY761NTsjkaos gRAiJK6eu8xI10IwzGbji1gTWKI3w0+8HIciG0I1DwA6RQQnRzHwerimRjQF8w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bB9BQ0WVdz1SWl; Mon, 02 Jun 2025 23:33:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 552NX1tE061537; Mon, 2 Jun 2025 23:33:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 552NX1uN061534; Mon, 2 Jun 2025 23:33:01 GMT (envelope-from git) Date: Mon, 2 Jun 2025 23:33:01 GMT Message-Id: <202506022333.552NX1uN061534@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Robert Clausecker Subject: git: e698e4a53773 - main - lib/libmd: disable SHA1 AVX2 kernel List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fuz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e698e4a537736f6a7dd9a386e00997d7fb08e83f Auto-Submitted: auto-generated The branch main has been updated by fuz: URL: https://cgit.FreeBSD.org/src/commit/?id=e698e4a537736f6a7dd9a386e00997d7fb08e83f commit e698e4a537736f6a7dd9a386e00997d7fb08e83f Author: Robert Clausecker AuthorDate: 2025-06-02 22:54:32 +0000 Commit: Robert Clausecker CommitDate: 2025-06-02 23:27:00 +0000 lib/libmd: disable SHA1 AVX2 kernel Seems like there is a bug lurking somewhere in the code. This was not caught during my testing. Disable the affected kernel for now while I figure out what is wrong with it. To reproduce, run jot -s '' -b 'a' -n 1000000 | sha1 This should yield 34aa973cd4c4daa4f61eeb2bdbad27316534016f, but gives fe161a71d7941e3d63a9cacadc4f20716a721944 with the broken code. Only the amd64/avx2 kernel is affected, the others seem to operate correctly. Reported by: olivier Fixes: 8b4684afcde3930eb49490f0b8431c4cb2ad9a46 --- lib/libmd/amd64/sha1dispatch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libmd/amd64/sha1dispatch.c b/lib/libmd/amd64/sha1dispatch.c index 86509195d56e..6c4d43b95ac9 100644 --- a/lib/libmd/amd64/sha1dispatch.c +++ b/lib/libmd/amd64/sha1dispatch.c @@ -47,8 +47,10 @@ DEFINE_UIFUNC(, void, sha1_block, (SHA1_CTX *, const void *, size_t)) { if (cpu_stdext_feature & CPUID_STDEXT_SHA) return (_libmd_sha1block_shani); +#if 0 if ((cpu_stdext_feature & AVX2_STDEXT_NEEDED) == AVX2_STDEXT_NEEDED) return (sha1block_avx2_wrapper); +#endif else return (_libmd_sha1block_scalar); }