From owner-svn-src-all@FreeBSD.ORG Mon Feb 2 00:45:31 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70C616C for ; Mon, 2 Feb 2015 00:45:31 +0000 (UTC) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D114CB9 for ; Mon, 2 Feb 2015 00:45:30 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id l6so28010972qcy.12 for ; Sun, 01 Feb 2015 16:45:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=e8Wqg9T5Awgrg+K+jUW7+9nLUpKndxVis+H/+Zx4zG4=; b=hCSaMWilI1uYnPSmP2YcOa7Irp/smhLDyfxa96UF4CRbsGLX7c56TsNLXL8pz8leKH cNpjg8wKOGVm/IW0MDSv0wgVOggX3U/vdhJFHDmnkUPvwqfepB2x1m3T7JXA5wgCcYzG B7CDrETsJTWW2VqBjuWm76WQARFpvULFNmXKaNNSHTtxd0mwM/1GXeQzGMrTpR/6508L cvBRTFSA287zq8FKig5eORJkOVIENtOvMHAIEqB9zEoYEU32ZUyGrETW2YgdiHQ/QPaS /WQoe2B1K0Zdn8x+j47vGw4kpWXKimvTV7qHy8cguEriVuci0HGNDzcE1VQA94N0Hjs1 m8Ug== X-Gm-Message-State: ALoCoQkxJLYdUyEjZVi3DhGkPmBurLqqji/g4NEnIgO1ht6v1JtZn3siHn61GjL1V5U9TtPmT6o9 MIME-Version: 1.0 X-Received: by 10.229.68.202 with SMTP id w10mr36682528qci.13.1422837923425; Sun, 01 Feb 2015 16:45:23 -0800 (PST) Received: by 10.140.88.103 with HTTP; Sun, 1 Feb 2015 16:45:23 -0800 (PST) In-Reply-To: References: <201502020017.t120Hb2g095087@svn.freebsd.org> Date: Sun, 1 Feb 2015 17:45:23 -0700 Message-ID: Subject: Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Will Andrews To: Davide Italiano Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , Steven Hartland , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 00:45:31 -0000 On Sunday, February 1, 2015, Davide Italiano wrote: > On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland > wrote: > > Author: smh > > Date: Mon Feb 2 00:17:36 2015 > > New Revision: 278040 > > URL: https://svnweb.freebsd.org/changeset/base/278040 > > > > Log: > > Prevent inlining txg_quiesce > > > > This allows dtrace to monitor the calls to txg_quiesce which can be > really > > helpful. > > > > Also standardise __noinline order for arc_kmem_reap_now. > > > > Sponsored by: Multiplay > > > > > > I found this while I was at iXsystems, trying to port Richard Elling's > arc statistics utility to FreeBSD. > I do not disagree with the change in theory, but I never committed > this because I was worried of performance penalty. > Last time I checked Solaris/Illumos actually do not inline this > function without any particular directive (I guess this is mostly due > to difference in toolchain, in particular in the compiler), so it > shouldn't be a big deal, but if you have time, do you mind to check > the penalty introduced, if any, is negligible? > It should be negligible. The function is only called once per txg, which generally is only supposed to happen about 1-0.2Hz. --Will.