Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Nov 2017 16:39:08 +0100
From:      Sir l33tname <sirl33tname@gmail.com>
To:        Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        Steve Wills <swills@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r452729 - in head/archivers/lua51-zlib: . files
Message-ID:  <5060e446-06d0-9827-82d0-f16eff84ec4e@gmail.com>
In-Reply-To: <CAMHz58SsHgfMsas9Q-Lp9hPB1obKz_Xi23Rc13sQ9KkzisuXEQ@mail.gmail.com>
References:  <201710231827.v9NIRZbd091882@repo.freebsd.org> <CAMHz58SsHgfMsas9Q-Lp9hPB1obKz_Xi23Rc13sQ9KkzisuXEQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi sunpoet,

Sorry I totally forgot this mail.

> Shouldn't lua51- be the PKGNAMEPREFIX and zlib (or lua-zlib) be the
PORTNAME?

Yeah this would make more sense. I did it the other way around because I
didn't know better.
I will update that with the next update or if it bothers you go ahead an
change it.

Regards l33tanme


On 10/23/2017 08:36 PM, Sunpoet Po-Chuan Hsieh wrote:
> On Tue, Oct 24, 2017 at 2:27 AM, Steve Wills <swills@freebsd.org
> <mailto:swills@freebsd.org>> wrote:
>
>     Author: swills
>     Date: Mon Oct 23 18:27:34 2017
>     New Revision: 452729
>     URL: https://svnweb.freebsd.org/changeset/ports/452729
>     <https://svnweb.freebsd.org/changeset/ports/452729>;
>
>     Log:
>       archivers/lua51-zlib update 1.1 to 1.2
>
>       PR:           222959
>       Submitted by: Sir l33tname <sirl33tname@gmail.com
>     <mailto:sirl33tname@gmail.com>> (maintainer)
>
>     Modified:
>       head/archivers/lua51-zlib/Makefile
>       head/archivers/lua51-zlib/distinfo   (contents, props changed)
>       head/archivers/lua51-zlib/files/patch-Makefile   (contents,
>     props changed)
>
>     Modified: head/archivers/lua51-zlib/Makefile
>     ==============================================================================
>     --- head/archivers/lua51-zlib/Makefile  Mon Oct 23 18:27:32 2017 
>           (r452728)
>     +++ head/archivers/lua51-zlib/Makefile  Mon Oct 23 18:27:34 2017 
>           (r452729)
>     @@ -2,7 +2,7 @@
>      # $FreeBSD$
>
>      PORTNAME=      lua51
>     -PORTVERSION=   1.1
>     +PORTVERSION=   1.2
>      DISTVERSIONPREFIX=v
>      CATEGORIES=    archivers
>      PKGNAMESUFFIX= -zlib
>
>
> Hello,
>
> Shouldn't lua51- be the PKGNAMEPREFIX and zlib (or lua-zlib) be the
> PORTNAME?
> Maintainer is cc'd.
>
> Regards,
> sunpoet
>
>
>     Modified: head/archivers/lua51-zlib/distinfo
>     ==============================================================================
>     --- head/archivers/lua51-zlib/distinfo  Mon Oct 23 18:27:32 2017 
>           (r452728)
>     +++ head/archivers/lua51-zlib/distinfo  Mon Oct 23 18:27:34 2017 
>           (r452729)
>     @@ -1,3 +1,3 @@
>     -TIMESTAMP = 1483616981
>     -SHA256 (brimworks-lua-zlib-v1.1_GH0.tar.gz) =
>     9f0820cc14873248a0c5ae22623cb2fc767fb830e47f6b34b01d71a6e1db2356
>     -SIZE (brimworks-lua-zlib-v1.1_GH0.tar.gz) = 16572
>     +TIMESTAMP = 1507829619
>     +SHA256 (brimworks-lua-zlib-v1.2_GH0.tar.gz) =
>     26b813ad39c94fc930b168c3418e2e746af3b2e80b92f94f306f6f954cc31e7d
>     +SIZE (brimworks-lua-zlib-v1.2_GH0.tar.gz) = 16612
>
>     Modified: head/archivers/lua51-zlib/files/patch-Makefile
>     ==============================================================================
>     --- head/archivers/lua51-zlib/files/patch-Makefile      Mon Oct 23
>     18:27:32 2017        (r452728)
>     +++ head/archivers/lua51-zlib/files/patch-Makefile      Mon Oct 23
>     18:27:34 2017        (r452729)
>     @@ -1,4 +1,4 @@
>     ---- Makefile.orig      2016-11-05 19:21:22 UTC
>     +--- Makefile.orig      2017-01-03 01:42:12 UTC
>      +++ Makefile
>      @@ -3,7 +3,7 @@
>       LUAPATH  ?= /usr/share/lua/5.1
>     @@ -19,11 +19,11 @@
>
>       BSD_CFLAGS  = -O2 -fPIC $(WARN) $(INCDIR) $(DEFS)
>      -BSD_LDFLAGS = -O -shared -fPIC $(LIBDIR)
>     -+BSD_LDFLAGS = -O -fPIC -shared $(LUALIBDIR)
>     ++BSD_LDFLAGS = -O2 -shared $(LUALIBDIR)
>
>       LNX_CFLAGS  = -O2 -fPIC $(WARN) $(INCDIR) $(DEFS)
>      -LNX_LDFLAGS = -O -shared -fPIC $(LIBDIR)
>     -+LNX_LDFLAGS = -O -shared -fPIC $(LUALIBDIR)
>     ++LNX_LDFLAGS = -O2 -shared -fPIC $(LUALIBDIR)
>
>       MAC_ENV     = env MACOSX_DEPLOYMENT_TARGET='$(MACVER)'
>       MAC_CFLAGS  = -O2 -fPIC -fno-common $(WARN) $(INCDIR) $(DEFS)
>     _______________________________________________
>     svn-ports-all@freebsd.org <mailto:svn-ports-all@freebsd.org>
>     mailing list
>     https://lists.freebsd.org/mailman/listinfo/svn-ports-all
>     <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>;
>     To unsubscribe, send any mail to
>     "svn-ports-all-unsubscribe@freebsd.org
>     <mailto:svn-ports-all-unsubscribe@freebsd.org>"
>
>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5060e446-06d0-9827-82d0-f16eff84ec4e>