From owner-freebsd-net@FreeBSD.ORG Tue Apr 7 09:24:45 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8ED5E1065672; Tue, 7 Apr 2009 09:24:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 64BA38FC0C; Tue, 7 Apr 2009 09:24:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id E6CBE46B9D; Tue, 7 Apr 2009 05:24:44 -0400 (EDT) Date: Tue, 7 Apr 2009 10:24:44 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Sepherosa Ziehau In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org, Ivan Voras Subject: Re: Advice on a multithreaded netisr patch? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 09:24:45 -0000 On Tue, 7 Apr 2009, Sepherosa Ziehau wrote: >> This issue is almost entirely independent from things like the cache line >> miss issue, unless you hit the uncommon case of having to do work in >> m_pullup(), in which case life sucks. >> >> It would be useful to use DTrace to profile a number of the workfull >> m_foo() functions to make sure we're not hitting them in normal workloads, >> btw. > > I highly suspect m_pullup will take any real effect on RX path, given how > most of drivers allocate the mbuf for RX ring (all RX mbufs should be > mclusters). Agreed, but it's good to be sure one is right about these things. :-) Robert N M Watson Computer Laboratory University of Cambridge