From owner-svn-ports-all@freebsd.org  Thu Mar 31 16:02:12 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13BEEAE376D;
 Thu, 31 Mar 2016 16:02:12 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E63D131C;
 Thu, 31 Mar 2016 16:02:11 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id b7ef2e4e
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 31 Mar 2016 09:55:28 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: svn commit: r412231 - in head: databases/p5-DBIx-Class-Helpers
 devel/p5-Class-Spiffy devel/p5-Config-Validator devel/p5-IO-Pipely
 devel/p5-Minilla devel/p5-Moo devel/p5-Perl-Version devel/p5-Perl6-...
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201603311523.u2VFNDes034507@repo.freebsd.org>
Date: Thu, 31 Mar 2016 09:55:26 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <3987FBEA-BCEA-4B48-9AFE-4959BD062EDD@adamw.org>
References: <201603311523.u2VFNDes034507@repo.freebsd.org>
To: Mathieu Arnold <mat@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2016 16:02:12 -0000

> On 31 Mar, 2016, at 9:23, Mathieu Arnold <mat@FreeBSD.org> wrote:
>=20
> Author: mat
> Date: Thu Mar 31 15:23:13 2016
> New Revision: 412231
> URL: https://svnweb.freebsd.org/changeset/ports/412231
>=20
> Log:
>  Cleanup dependencies on lang/p5-Scalar-List-Utils.
>=20
>  The different cases are:
>=20
>  - Only bring it if the one bundled with Perl is outdated.
>  - The version bundled with all our Perl is sufficient.
>  - Scalar-List-Util is not really needed by the port.
>    (looking for /(Sub|Scalar|List)::Util/ returns nothing.)
>=20
>  While there, do some minor cleanup that caught my eye.

Hi Mat,

At least for Moo I think this change might be wrong.

The p5-Scalar-List-Util dependency was brought in for the XS option, for =
the speed boost provided by Sub::Util. Sub::Util wasn't added to core =
until 5.21.4.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org