From owner-cvs-src-old@FreeBSD.ORG  Wed Mar 17 20:30:59 2010
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5DDA106567A
	for <cvs-src-old@freebsd.org>; Wed, 17 Mar 2010 20:30:59 +0000 (UTC)
	(envelope-from gavin@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id A438A8FC20
	for <cvs-src-old@freebsd.org>; Wed, 17 Mar 2010 20:30:59 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o2HKUx3M076207
	for <cvs-src-old@freebsd.org>; Wed, 17 Mar 2010 20:30:59 GMT
	(envelope-from gavin@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o2HKUx7Z076206
	for cvs-src-old@freebsd.org; Wed, 17 Mar 2010 20:30:59 GMT
	(envelope-from gavin@repoman.freebsd.org)
Message-Id: <201003172030.o2HKUx7Z076206@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	gavin@repoman.freebsd.org using -f
From: Gavin Atkinson <gavin@FreeBSD.org>
Date: Wed, 17 Mar 2010 20:30:37 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: RELENG_7
Subject: cvs commit: src/sbin/growfs growfs.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2010 20:30:59 -0000

gavin       2010-03-17 20:30:37 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_7)
    sbin/growfs          growfs.c 
  Log:
  SVN rev 205260 on 2010-03-17 20:30:37Z by gavin
  
  Merge r201401 from head:
  
    Remove dead code.  This section of code is only run in the
    (sblock.fs_magic == FS_UFS1_MAGIC) case, so the check within the
    loop is redundant.
  
  Merge 203835 from head:
  
    When growing a UFS1 filesystem, we need to initialise all inodes in any new
    cylinder groups that are created.  When the filesystem is first created,
    newfs always initialises the first two blocks of inodes, and then in the
    UFS1 case will also initialise the remaining inode blocks.  The changes in
    growfs.c 1.23 broke the initialisation of all inodes, seemingly based on
    this implementation detail in newfs(8).  The result was that instead of
    initialising all inodes, we would actually end up initialising all but the
    first two blocks of inodes.  If the filesystem was grown into empty
    (all-zeros) space then the resulting filesystem was fine, however when
    grown onto non-zeroed space the filesystem produced would appear to have
    massive corruption on the first fsck after growing.
    A test case for this problem can be found in the PR audit trail.
  
    Fix this by once again initialising all inodes in the UFS1 case.
  
  PR:             bin/115174
  Submitted by:   "Nate Eldredge" <nge cs.hmc.edu>
  Reviewed by:    mjacob
  
  Revision  Changes    Path
  1.25.2.3  +6 -14     src/sbin/growfs/growfs.c