From owner-freebsd-net@FreeBSD.ORG Fri Jun 14 11:01:29 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A27E8981 for ; Fri, 14 Jun 2013 11:01:29 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 1A0A510ED for ; Fri, 14 Jun 2013 11:01:28 +0000 (UTC) Received: (qmail 8038 invoked from network); 14 Jun 2013 11:30:11 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 14 Jun 2013 11:30:11 -0000 Message-ID: <51BAF1BA.8000603@freebsd.org> Date: Fri, 14 Jun 2013 12:34:34 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: [PATH] ALTQ(9) codel algorithm implementation References: <20130614095125.GQ12443@FreeBSD.org> In-Reply-To: <20130614095125.GQ12443@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Ermal Lu?i , freebsd-net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jun 2013 11:01:29 -0000 On 14.06.2013 11:51, Gleb Smirnoff wrote: > Ermal, > > On Mon, Jun 10, 2013 at 03:43:12PM +0200, Ermal Lu?i wrote: > E> at location [1] can be found a patch for Codel[3] algorithm implementation. > E> > E> Triggered by a mail to the mailing lists[2] of OpenBSD i completed the > E> implementation for FreeBSD. > E> > E> It allows to use codel as the single configured discipline on an interface. > E> Also it can be used as a sub discipline of existing queueing disciplines > E> already present. > E> > E> The work has been tested and confirmed working without issues in pfSense. > E> > E> Any objections on pushing this into FreeBSD? > E> > E> [1] > E> https://github.com/pfsense/pfsense-tools/blob/master/patches/RELENG_10_0/altq_codel.diff > E> [2] http://permalink.gmane.org/gmane.os.openbsd.tech/29745 > E> [3] http://www.bufferbloat.net/projects/codel/wiki > > I'm afraid we can't grow mbuf packet header with 8 bytes just to satisfy > the ALTQ codel algo, which would definitely have a limited usage among > FreeBSD users. Thus, "enqueue_time" should go into mbuf_tags(9) not into > mbuf packet header. Agreed. We don't have space for that in the mbuf header. There's some other fields that may be repurposed though, the header pointer for example which is almost entirely unused. With some updates to the TSO and Checksum offload mechanism I have in the pipeline the "header" field can be easily repurposed. Though I'm against an "obscure" ALTQ mechanism having its own mbuf header field as such. It must be a generic field that can be used by others as well. -- Andre