From owner-svn-src-head@FreeBSD.ORG  Sun Aug 23 05:53:21 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 58FB4106568B;
	Sun, 23 Aug 2009 05:53:21 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-yw0-f202.google.com (mail-yw0-f202.google.com
	[209.85.211.202])
	by mx1.freebsd.org (Postfix) with ESMTP id EDDBC8FC08;
	Sun, 23 Aug 2009 05:53:20 +0000 (UTC)
Received: by ywh40 with SMTP id 40so2372100ywh.14
	for <multiple recipients>; Sat, 22 Aug 2009 22:53:20 -0700 (PDT)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.150.17.2 with SMTP id 2mr4238345ybq.334.1251006800238; Sat, 22 
	Aug 2009 22:53:20 -0700 (PDT)
In-Reply-To: <200908230545.n7N5jcpZ047952@svn.freebsd.org>
References: <200908230545.n7N5jcpZ047952@svn.freebsd.org>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Sat, 22 Aug 2009 22:53:00 -0700
X-Google-Sender-Auth: a0006664ed71865e
Message-ID: <eaa228be0908222253x2d0c06ffm1ae015b2d1112491@mail.gmail.com>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r196435 - head/sys/conf
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Aug 2009 05:53:21 -0000

On Sat, Aug 22, 2009 at 22:45, Doug Barton<dougb@freebsd.org> wrote:
> Author: dougb
> Date: Sun Aug 23 05:45:38 2009
> New Revision: 196435
> URL: http://svn.freebsd.org/changeset/base/196435
>
> Log:
> =A0The svnversion string is only relevant when newvers.sh is called
> =A0during the kernel build process, the other places that call the script
> =A0do not make use of that information. So restrict execution of the
> =A0svnversion-related code to the kernel build context.

This seems to assume that the kernel is always checked out in a
directory called 'sys', is that right?  That isn't always true in my
experience, and I have a bad habit of keeping multiple kernel trees
checked out named things like 'sys-head', etc.  I could be misreading
the code, which gave only constructs I'm not very familiar with for
determining whether it's being used for a kernel build.

Is it harmful to include the svnversion stuff for other newvers.sh
users?  Could they just set an environment variable to indicate they
want it excluded?  Or could you check the environment for kernel
build-related variables?  Or even set a variable when running
newvers.sh for the kernel to explicitly request svnversion inclusion?

Juli.