From owner-svn-src-head@freebsd.org Fri Feb 24 08:27:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD885CEAE6A; Fri, 24 Feb 2017 08:27:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34164131E; Fri, 24 Feb 2017 08:27:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v1O8RVPd069701 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 24 Feb 2017 10:27:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v1O8RVPd069701 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v1O8RVwu069700; Fri, 24 Feb 2017 10:27:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 24 Feb 2017 10:27:31 +0200 From: Konstantin Belousov To: Eric van Gyzen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314179 - in head: contrib/netbsd-tests/lib/librt include lib/libc/gen lib/libc/include share/man/man3 sys/kern Message-ID: <20170224082731.GT2092@kib.kiev.ua> References: <201702231936.v1NJadRa029404@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702231936.v1NJadRa029404@repo.freebsd.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 08:27:36 -0000 On Thu, Feb 23, 2017 at 07:36:39PM +0000, Eric van Gyzen wrote: > Modified: head/include/semaphore.h > ============================================================================== > --- head/include/semaphore.h Thu Feb 23 19:32:25 2017 (r314178) > +++ head/include/semaphore.h Thu Feb 23 19:36:38 2017 (r314179) > @@ -59,6 +59,8 @@ int sem_init(sem_t *, int, unsigned int > sem_t *sem_open(const char *, int, ...); > int sem_post(sem_t *); > int sem_timedwait(sem_t * __restrict, const struct timespec * __restrict); > +int sem_clockwait_np(sem_t * __restrict, __clockid_t, int, > + const struct timespec *, struct timespec *); I argue that semaphore.h is POSIX include file and the declaration of sem_clockwait_np(), despite being in implementation (non-portable) namespace, still should be braced with #if __BSD_VISIBLE. > int sem_trywait(sem_t *); > int sem_unlink(const char *); > int sem_wait(sem_t *); >