From owner-cvs-src@FreeBSD.ORG Thu Dec 27 17:09:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF5ED16A41B; Thu, 27 Dec 2007 17:09:59 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from galain.elvandar.org (galain.elvandar.org [217.148.169.56]) by mx1.freebsd.org (Postfix) with ESMTP id 7561313C457; Thu, 27 Dec 2007 17:09:59 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from evilcoder.xs4all.nl ([195.64.94.120] helo=elvandar.local) by galain.elvandar.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1J7wF4-0002WW-9D; Thu, 27 Dec 2007 18:09:58 +0100 Message-ID: <4773DC96.9040307@FreeBSD.org> Date: Thu, 27 Dec 2007 18:10:46 +0100 From: Remko Lodder User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Warner Losh References: <200712271638.lBRGcTu9071266@repoman.freebsd.org> In-Reply-To: <200712271638.lBRGcTu9071266@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2007 17:09:59 -0000 Warner Losh wrote: > imp 2007-12-27 16:38:29 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_bio.c vfs_mount.c > Log: > A partial solution to some of the 'pull the umass device with a > mounted FS' problems. These are more along the lines of 'avoiding an > avoidable panic' than a complete solution to removable devices. We > now close the barn door after the horse has gotten lose and has been > hit by a truck, as it were. The barn no longer catches fire in this > case, but the horse is still dead :-). > > The vfs_bio.c fix causes us not to put a failed write back into the > dirty pool if the error returned was ENXIO. In that case, the buffer > is treated like any other clean buffer that's being retured. ENXIO > means the device isn't there anymore and will never be there again in > the future, so retrying is futile. > > The vfs_mount.c fix treats 'ENXIO' as success for unmounting a file > system. If the device is gone, retrying later won't help and we'll > never be able to unmount the device. > > These two are part of a larger patch set submitted by the author. The > other patches will be forth coming. I added comments to these two > patches. > > Submitted by: Henrik Gulbrandsen > Reviewed by: phk@ > PR: usb/46176 (partial) > > Revision Changes Path > 1.531 +4 -0 src/sys/kern/vfs_bio.c > 1.269 +7 -2 src/sys/kern/vfs_mount.c Hurray! -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News