Date: Wed, 17 Nov 2004 17:44:53 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: Ruslan Ermilov <ru@FreeBSD.org> Subject: Re: New ACPI PCI Link Routing code Message-ID: <200411171744.53665.jhb@FreeBSD.org> In-Reply-To: <419BC030.5080803@root.org> References: <200411111737.00537.jhb@FreeBSD.org> <20041117205952.GB68320@ip.net.ua> <419BC030.5080803@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 17 November 2004 04:18 pm, Nate Lawson wrote: > Ruslan Ermilov wrote: > > On Wed, Nov 17, 2004 at 11:24:48AM -0500, John Baldwin wrote: > >>On Wednesday 17 November 2004 10:41 am, Ruslan Ermilov wrote: > >>>I get a panic on boot with this change. I don't have a serial > >>>console attached to this notebook, but if needs be it can be > >>>arranged (tomorrow). The panic I get is as follows: > >>> > >>>panic: Assertion resource->Data.Irq.NumberOfInterrupts == 1 failed at > >>>.../acpi_pci_link.c:497 > >> > >>Can you print out what 'NumberOfInterrupts' is before the printf? Drew > >> has a machine that has hit the same panic as well. > > > > It's zero. > > Is line 497 in _CRS? It's ok to return 0 interrupts from _CRS if the > link was disabled. Erm, unless I've got a logic bug I don't run the KASSERT() for zero interrupts. Oh darn, I left a bogus KASSERT() in in the function that does the actual routing. The assertion's on lines 497 and 511 can be dropped. I'll update the patch in a second. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411171744.53665.jhb>