From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Aug 28 17:50:06 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C0E51065670 for ; Fri, 28 Aug 2009 17:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 04C158FC23 for ; Fri, 28 Aug 2009 17:50:06 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7SHo558048050 for ; Fri, 28 Aug 2009 17:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7SHo5UJ048049; Fri, 28 Aug 2009 17:50:05 GMT (envelope-from gnats) Resent-Date: Fri, 28 Aug 2009 17:50:05 GMT Resent-Message-Id: <200908281750.n7SHo5UJ048049@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andriy Gapon Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36C28106566C for ; Fri, 28 Aug 2009 17:44:52 +0000 (UTC) (envelope-from avg@starpoint.kiev.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3BC6E8FC17 for ; Fri, 28 Aug 2009 17:44:50 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA28584 for ; Fri, 28 Aug 2009 20:34:28 +0300 (EEST) (envelope-from avg@starpoint.kiev.ua) Received: from odyssey.starpoint.kiev.ua (localhost [127.0.0.1]) by odyssey.starpoint.kiev.ua (8.14.3/8.14.3) with ESMTP id n7SHYS0H091563 for ; Fri, 28 Aug 2009 20:34:28 +0300 (EEST) (envelope-from avg@odyssey.starpoint.kiev.ua) Received: (from avg@localhost) by odyssey.starpoint.kiev.ua (8.14.3/8.14.3/Submit) id n7SHYSEg091562; Fri, 28 Aug 2009 20:34:28 +0300 (EEST) (envelope-from avg) Message-Id: <200908281734.n7SHYSEg091562@odyssey.starpoint.kiev.ua> Date: Fri, 28 Aug 2009 20:34:28 +0300 (EEST) From: Andriy Gapon To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/138272: graphics/exiv2: add patch from upstream X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2009 17:50:06 -0000 >Number: 138272 >Category: ports >Synopsis: graphics/exiv2: add patch from upstream >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Aug 28 17:50:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Andriy Gapon >Release: FreeBSD 7.2-STABLE amd64 >Organization: >Environment: exiv2-0.18,1 >Description: I am getting the following crash when I try to import a certain image with digikam: #6 0x000000080687a55c in thr_kill () from /lib/libc.so.7 #7 0x0000000806901233 in abort () from /lib/libc.so.7 #8 0x00000008068ea119 in __assert () from /lib/libc.so.7 #9 0x000000080253af0a in Exiv2::Internal::TiffMnEntry::doCount () from /usr/local/lib/libexiv2.so.7 #10 0x000000080253b355 in Exiv2::Internal::TiffDirectory::writeDirEntry () from /usr/local/lib/libexiv2.so.7 #11 0x000000080253e4ff in Exiv2::Internal::TiffDirectory::doWrite () from /usr/local/lib/libexiv2.so.7 #12 0x000000080253c16b in Exiv2::Internal::TiffSubIfd::doWriteData () from /usr/local/lib/libexiv2.so.7 #13 0x000000080253b4bb in Exiv2::Internal::TiffDirectory::doWriteData () from /usr/local/lib/libexiv2.so.7 #14 0x000000080253e6a0 in Exiv2::Internal::TiffDirectory::doWrite () from /usr/local/lib/libexiv2.so.7 #15 0x0000000802542d9e in Exiv2::Internal::TiffParserWorker::encode () from /usr/local/lib/libexiv2.so.7 #16 0x0000000802542ef1 in Exiv2::TiffParser::encode () from /usr/local/lib/libexiv2.so.7 #17 0x00000008024e4382 in Exiv2::ExifParser::encode () from /usr/local/lib/libexiv2.so.7 #18 0x0000000802326b9e in KExiv2Iface::KExiv2::getExif () from /usr/local/lib/libkexiv2.so.5 #19 0x0000000800a78e17 in Digikam::ImagePropertiesSideBarCamGui::itemChanged () from /usr/local/lib/libdigikam.so.0 The image was taken with a Nokia phone camera and contains some non-empty Exif.Photo.MakerNote (type Ascii, size 1088). I believe that this issue was fixed upstream: http://dev.exiv2.org/repositories/revision/exiv2/1743 http://dev.exiv2.org/issues/show/615 I applied this change in my local ports tree and it seems to fix the problem. I also see that Debian folks have included this change into their package of exiv2. Could we please do the same? >How-To-Repeat: Try to import into digikam a suitable image (photo) with non-empty Exif.Photo.MakerNote that has any type other than 'undefined'. >Fix: Please add the following patch obtained from upstream to files/. --- patch-tiffcomposite.cpp begins here --- Index: tiffcomposite.cpp =================================================================== --- src/tiffcomposite.cpp (revision 1742) +++ src/tiffcomposite.cpp (revision 1743) @@ -688,9 +688,13 @@ uint32_t TiffMnEntry::doCount() const { - // Count of tag Exif.Photo.MakerNote is the size of the Makernote in bytes + if (!mn_) { + return TiffEntryBase::doCount(); + } + // Count of IFD makernote in tag Exif.Photo.MakerNote is the size of the + // Makernote in bytes assert(tiffType() == ttUndefined); - return size(); + return mn_->size(); } uint32_t TiffArrayEntry::doCount() const --- patch-tiffcomposite.cpp ends here --- >Release-Note: >Audit-Trail: >Unformatted: